-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
ty::print::pretty's p! macro should support string literals. #70948
Copy link
Copy link
Closed
Labels
A-prettyArea: Pretty printing (including `-Z unpretty`)Area: Pretty printing (including `-Z unpretty`)C-cleanupCategory: PRs that clean code up or issues documenting cleanup.Category: PRs that clean code up or issues documenting cleanup.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.
Metadata
Metadata
Assignees
Labels
A-prettyArea: Pretty printing (including `-Z unpretty`)Area: Pretty printing (including `-Z unpretty`)C-cleanupCategory: PRs that clean code up or issues documenting cleanup.Category: PRs that clean code up or issues documenting cleanup.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.
Type
Fields
Give feedbackNo fields configured for issues without a type.
E.g. printing
ty::Slice(ty)uses:but we could allow writing it like this, by letting the macro use
$...:literal:But I'm not sure the macro can handle it easily.
Maybe we should just have
Printimplemented for more types and just makep!(a, b, c)printa,bandc(and we can then rename it toprint!).This issue has been assigned to @jakevossen5 via this comment.