Currently, htmldocck (the script that runs src/test/rustdoc tests) has two
primary test assertions: @has and @!has. @has checks for the presence of
text in tags selected with an XPath selector. @!has does the same, except it
checks for the absence of text. However, it is very easy to write !@has
instead of @!has by mistake (see #80565 for an example of some tests that used
!@has and had to be fixed), but !@has will be silently ignored by htmldocck.
Instead, htmldocck should either accept !@has or error out and cause the test
to fail. Otherwise, it's confusing to people who are new to htmldocck and, even
worse, we will likely end up with tests that have silently-ignored assertions.
cc @GuillaumeGomez
Currently, htmldocck (the script that runs
src/test/rustdoctests) has twoprimary test assertions:
@hasand@!has.@haschecks for the presence oftext in tags selected with an XPath selector.
@!hasdoes the same, except itchecks for the absence of text. However, it is very easy to write
!@hasinstead of
@!hasby mistake (see #80565 for an example of some tests that used!@hasand had to be fixed), but!@haswill be silently ignored by htmldocck.Instead, htmldocck should either accept
!@hasor error out and cause the testto fail. Otherwise, it's confusing to people who are new to htmldocck and, even
worse, we will likely end up with tests that have silently-ignored assertions.
cc @GuillaumeGomez