-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
rustdoc: search box flickers on page load #90246
Copy link
Copy link
Closed
Labels
A-rustdoc-uiArea: Rustdoc UI (generated HTML)Area: Rustdoc UI (generated HTML)T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.Relevant to the rustdoc team, which will review and decide on the PR/issue.
Metadata
Metadata
Assignees
Labels
A-rustdoc-uiArea: Rustdoc UI (generated HTML)Area: Rustdoc UI (generated HTML)T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.Relevant to the rustdoc team, which will review and decide on the PR/issue.
Type
Fields
Give feedbackNo fields configured for issues without a type.
Steps to reproduce:
The search box has for a long time been disabled on page load, until the JS runs. It being grey is a side effect of #85367. Before that, our
search-focus:disabledstyle wasn't getting applied. After that, it is. As a quick fix I think we should remove the grey styling on the disabled search bar. I know this means that no-JS users won't have as good a visual indication that the search bar is disabled. Perhaps we should address this by having styles inside a<noscript>tag that hide the search bar entirely.It's good to minimize the number of changes that happen during page load - this reduces visual distractions and help page loads feel fast.