Deprecated suggestion message could be better

[ChrisDenton]

#![feature(deprecated_suggestion)] (#94785) produces warning messages that I think could be improved? The current suggestion message doesn't seem ideal to me:

warning: use of deprecated constant `std::sync::ONCE_INIT`: the `new` function is now preferred
 --> src/main.rs:4:32
  |
4 |     const _: Once = std::sync::ONCE_INIT;
  |                                ^^^^^^^^^ help: replace the use of the deprecated constant: `Once::new()`
  |
  = note: `#[warn(deprecated)]` on by default

Specifically this part sounds to me more like Once::new() is the deprecated constant:

help: replace the use of the deprecated constant: Once::new()

I think something like this would be better, but I don't know how easy it would be to implement a more natural sentence:

help: replace the use of the deprecated constant with Once::new()

[compiler-errors]

This is because it's a suggestion, but being rendered inline. You could bump it up to a verbose suggestion so it renders more distinctly.

[ChrisDenton]

Hm, thinking more about it, could it not be simplified to:

help: try replacing with: Once::new()

As then the help message would focus on what's actionable without repeating less essential information.

[compiler-errors]

The problem is that this is a suggestion, and when suggestions are rendered inline they always are presented like {message}: {code}

edit: whoops, i guess i missed the colon in your revised message. i guess it could be shortened like that.

[ChrisDenton]

Yeah, sorry I edited once I started actually playing with this.

[compiler-errors]

I think it's meaningful for the suggestion's message to say what it's doing -- "try replacing with" seems a bit terse.

I think I still prefer how this would render if we just bumped the suggestion to a verbose (not inclined) suggestion.

[ChrisDenton]

Ah ok. My thought was just that it's essentially repeating warning message using slightly different language.