Conversation
* Remove the `float: right` fallback from the main header, which hasn't been needed since IE11 support was dropped. * Remove `in-band` from low-level headers, which hasn't been needed since `.rightside` switched to `float: right` in 593d6d1 * Remove unreachable `.in-band > code, .in-band > .code-header` CSS, since the `in-band` class was attached to the `code-header` itself, not nested directly below it. * Use `rem` instead of `em` for code header margins. * This results in a slight change in spacing around impls and item-info, but since it makes it more consistent with the way methods are presented, it's probably fine.
…, r=davidtwco Clean up (sub)diagnostic derives The biggest chunk of this is unifying the parsing of subdiagnostic attributes (`#[error]`, `#[suggestion(...)]`, `#[label(...)]`, etc) between `Subdiagnostic` and `Diagnostic` type attributes as well as `Diagnostic` field attributes. It also improves a number of proc macro diagnostics. Waiting for rust-lang#101558.
…gillot Only generate closure def id for async fns with body Fixes rust-lang#102219
…example, r=thomcc Clarify Iterator::rposition code example Fixes rust-lang#101095. r? `@thomcc`
…umeGomez rustdoc: clean up `.out-of-band`/`.in-band` CSS | | method | impl |--------|--------|------ | before |  |  | after |  |  * Remove the `float: right` fallback from the main header, which hasn't been needed since IE11 support was dropped. * Remove `in-band` from low-level headers, which hasn't been needed since `.rightside` switched to `float: right` in rust-lang@593d6d1 * Remove unreachable `.in-band > code, .in-band > .code-header` CSS, since the `in-band` class was attached to the `code-header` itself, not nested directly below it. * Use `rem` instead of `em` for code header margins. * This results in a slight change in spacing around impls and item-info, but since it makes it more consistent with the way methods are presented, it's probably fine. Preview: http://notriddle.com/notriddle-rustdoc-demos/band/std/fs/struct.File.html
rustbot
added
A-translation
|
@bors r+ p=4 rollup=never |
bors
added
the
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
📌 Perf builds for each rolled up PR: previous master: 3288d3a305 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
|
Finished benchmarking commit (fe217c2): comparison URL. Overall result: ❌ regressions - ACTION NEEDEDNext Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Footnotes |
|
keccak and cranelift-codegen regressions look spurious to me based on historical graphs, with the last data point being the current PR.
|
davidtwco
removed
the
A-translation
10 participants
Successful merges:
.out-of-band/.in-bandCSS #102280 (rustdoc: clean up.out-of-band/.in-bandCSS)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup