Ban dashes in miropt test file names#103904
Merged
bors merged 1 commit intorust-lang:masterfrom Nov 3, 2022
Merged
Conversation
rustbot
added
T-bootstrap
jyn514
approved these changes
Nov 2, 2022
Member
jyn514
left a comment
jyn514
left a comment
There was a problem hiding this comment.
The tidy code LGTM :) I'll let someone from WG-mir-opt say whether they want this change, but it makes sense to me.
jyn514
removed
the
S-waiting-on-review
JakobDegen
force-pushed
the
mir-opt-dash
branch
from
1ffbabe to
3c1588b
Compare
JakobDegen
force-pushed
the
mir-opt-dash
branch
from
3c1588b to
0bd4f76
Compare
Contributor
|
@bors r+ p=1 bitrotty |
Collaborator
bors
added
S-waiting-on-bors
Contributor
|
This has annoyed me time and time again. Thank you for fixing it |
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
This was referenced Nov 3, 2022
Collaborator
|
Finished benchmarking commit (160b194): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. |
Contributor
Author
|
Surprised that survived even 9 hours without conflicts 😂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dashes in miropt test file names are annoying - specifically, they cause the test files to not be sorted next to their outputs, which makes it very difficult to tell what goes with what. This PR changes all files to use underscores and adds a blessable tidy check that enforces this.
r? @jyn514
This PR is obviously going to bitrot very quickly. Because of this, I'm going to wait at least 48 hours and until review comes back to allow people from @rust-lang/wg-mir-opt or elsewhere to lodge complaints if there are any. If not, I'll rebase the branch on Friday afternoon PST and ask that it be
r+'d withp=1at that time.