Walk through full path in point_at_path_if_possible

[compiler-errors]

We already had sufficient information to point at the [u8] in Option::<[u8]>::None (the fallback_param_to_point_at parameter), we just were neither using it nor walking through hir paths sufficiently to encounter it.

This should alleviate the need to add additional logic to extract params in a somewhat arbitrary manner of looking at the grandparent def path: #115219 (comment)

r? @estebank

[estebank]

@bors r+

[bors]

📌 Commit 13e8b13 has been approved by estebank

It is now in the queue for this repository.

[estebank]

Interestingly, I would have expected the span to point at () here, based on the output of the other tests.

[compiler-errors]

There's some subtlety in the ordering of what params to prefer over others. Right now we prefer non-self params over self params in qpaths, though arguably pointing at either of the params here is good enough.

[bors]

⌛ Testing commit 13e8b13 with merge ac89e16...

[bors]

☀️ Test successful - checks-actions
Approved by: estebank
Pushing ac89e16 to master...

[rust-timer]

Finished benchmarking commit (ac89e16): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	3.2%	[2.9%, 3.7%]	3
Regressions ❌ (secondary)	3.0%	[2.3%, 3.7%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	3.2%	[2.9%, 3.7%]	3

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 631.205s -> 632.821s (0.26%)
Artifact size: 315.72 MiB -> 315.71 MiB (-0.00%)