style-guide: Tweak Cargo.toml formatting to not put description last#120072
style-guide: Tweak Cargo.toml formatting to not put description last#120072joshtriplett wants to merge 1 commit intorust-lang:mainfrom
Cargo.toml formatting to not put description last#120072Conversation
Based on feedback from the Cargo team.
|
r? @yaahc (rustbot has picked a reviewer for you, use r? to override) |
|
Some changes occurred in src/doc/style-guide cc @rust-lang/style |
|
@rfcbot merge |
|
Team member @joshtriplett has proposed to merge this. The next step is review by the rest of the tagged team members: No concerns currently listed. Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! See this document for info about what commands tagged team members can give me. |
|
There was a suggestion on a rustfmt issue that we apply some sort of indicator that the set of Cargo.toml prescriptions is not exactly active/enforced, and I think that has some merit to it. I don't think it's absolutely necessary, but perhaps a small disclaimer note at the top or bottom would be beneficial |
|
🔔 This is now entering its final comment period, as per the review above. 🔔 |
|
The final comment period, with a disposition to merge, as per the review above, is now complete. As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed. This will be merged soon. |
|
@joshtriplett: I'd also like a small disclaimer like Caleb asked for (#120072 (comment)). r=me after @rustbot author |
|
@joshtriplett any updates on this? thanks |
Based on feedback from the Cargo team.