compiletest: fix outdated rmake.rs comment#125896
Merged
bors merged 1 commit intorust-lang:masterfrom Jun 3, 2024
Merged
Conversation
Collaborator
|
rustbot has assigned @compiler-errors. Use |
rustbot
added
A-testsuite
Member
Author
|
r? onur-ozkan since you reviewed the original PR |
compiler-errors
approved these changes
Jun 2, 2024
Contributor
|
@bors r+ rollup |
Collaborator
bors
added
S-waiting-on-bors
jieyouxu
added a commit
to jieyouxu/rust
that referenced
this pull request
Jun 2, 2024
…, r=compiler-errors compiletest: fix outdated rmake.rs comment Noticed in rust-lang#125827 (comment). I fixed the PR description but forgot to update the comment.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 2, 2024
Rollup of 5 pull requests Successful merges: - rust-lang#121062 (Change f32::midpoint to upcast to f64) - rust-lang#125808 (Migrate `run-make/c-link-to-rust-dylib` to `rmake.rs`) - rust-lang#125886 (Migrate run make issue 15460) - rust-lang#125890 (Improve compiletest expected/not found formatting) - rust-lang#125896 (compiletest: fix outdated rmake.rs comment) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 2, 2024
…kingjubilee Rollup of 6 pull requests Successful merges: - rust-lang#121062 (Change f32::midpoint to upcast to f64) - rust-lang#125808 (Migrate `run-make/c-link-to-rust-dylib` to `rmake.rs`) - rust-lang#125884 (Implement feature `integer_sign_cast`) - rust-lang#125890 (Improve compiletest expected/not found formatting) - rust-lang#125896 (compiletest: fix outdated rmake.rs comment) - rust-lang#125898 (typo: depending from -> on) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 3, 2024
Rollup merge of rust-lang#125896 - jieyouxu:compiletest-rmake-comment, r=compiler-errors compiletest: fix outdated rmake.rs comment Noticed in rust-lang#125827 (comment). I fixed the PR description but forgot to update the comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed in #125827 (comment). I fixed the PR description but forgot to update the comment.