Improve error when a compiler/library build fails in checktools.sh#127934
Merged
bors merged 1 commit intorust-lang:masterfrom Jul 19, 2024
Merged
Improve error when a compiler/library build fails in checktools.sh#127934bors merged 1 commit intorust-lang:masterfrom
checktools.sh#127934bors merged 1 commit intorust-lang:masterfrom
Conversation
rustbot
added
A-testsuite
Contributor
|
Makes sense! @bors r+ |
Collaborator
bors
added
S-waiting-on-bors
Member
Author
|
I checked the build logs now and it is building perhaps too much stuff, including things like |
Contributor
|
Maybe you can try to give each component name explicitly. Something like |
Member
|
@bors r- |
bors
added
S-waiting-on-author
Kobzol
force-pushed
the
checktools-better-error
branch
from
af95fd6 to
e3a22c9
Compare
Member
Author
|
Let's try |
Contributor
|
@bors r+ |
Collaborator
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jul 19, 2024
…onur-ozkan Improve error when a compiler/library build fails in `checktools.sh` Suggested by `@RalfJung` [here](rust-lang#127869 (comment)). `x86_64-gnu-tools` should take ~45 minutes, let's see if this doesn't regress it. r? `@onur-ozkan`
This was referenced Jul 19, 2024
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 19, 2024
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#112328 (Feat. adding ext that returns change_time) - rust-lang#126199 (Add `isqrt` to `NonZero<uN>`) - rust-lang#127856 (interpret: add sanity check in dyn upcast to double-check what codegen does) - rust-lang#127934 (Improve error when a compiler/library build fails in `checktools.sh`) - rust-lang#127960 (Cleanup dll/exe filename calculations in `run_make_support`) - rust-lang#127963 (Fix display of logo "border") - rust-lang#127967 (Disable run-make/split-debuginfo test for RISC-V 64) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 19, 2024
Rollup merge of rust-lang#127934 - Kobzol:checktools-better-error, r=onur-ozkan Improve error when a compiler/library build fails in `checktools.sh` Suggested by ``@RalfJung`` [here](rust-lang#127869 (comment)). `x86_64-gnu-tools` should take ~45 minutes, let's see if this doesn't regress it. r? ``@onur-ozkan``
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suggested by @RalfJung here.
x86_64-gnu-toolsshould take ~45 minutes, let's see if this doesn't regress it.r? @onur-ozkan