Hint on unknown escape of Unicode quotation marks in string literal#128906

lolbinarycat · 2024-08-09T21:46:55Z

I opted not to produce a suggestion, since it's not obvious what the user meant to do.

Fixes rust-lang#128858 I opted not to produce a suggestion, since it's not obvious what the user meant to do.

rustbot · 2024-08-09T21:47:03Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @estebank (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

@rustbot author: the review is finished, PR author should check the comments and take action accordingly
@rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

rust-log-analyzer · 2024-08-09T22:28:59Z

The job x86_64-gnu-llvm-17 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

------
 > importing cache manifest from ghcr.io/rust-lang/rust-ci-cache:3aacb9c90579defe09351ac5e8ee504359f8054da6326ff19038f1b7c90e3cb2aafe33685c6d9b76ee8d2ccbd187ca80c46ab5380485abdd8c0ce7d69cd8d8fd:
------
##[endgroup]
Setting extra environment values for docker:  --env ENABLE_GCC_CODEGEN=1 --env GCC_EXEC_PREFIX=/usr/lib/gcc/
[CI_JOB_NAME=x86_64-gnu-llvm-17]
---
sccache: Starting the server...
##[group]Configure the build
configure: processing command line
configure: 
configure: build.configure-args := ['--build=x86_64-unknown-linux-gnu', '--llvm-root=/usr/lib/llvm-17', '--enable-llvm-link-shared', '--set', 'rust.thin-lto-import-instr-limit=10', '--set', 'change-id=99999999', '--enable-verbose-configure', '--enable-sccache', '--disable-manage-submodules', '--enable-locked-deps', '--enable-cargo-native-static', '--set', 'rust.codegen-units-std=1', '--set', 'dist.compression-profile=balanced', '--dist-compression-formats=xz', '--set', 'rust.lld=false', '--disable-dist-src', '--release-channel=nightly', '--enable-debug-assertions', '--enable-overflow-checks', '--enable-llvm-assertions', '--set', 'rust.verify-llvm-ir', '--set', 'rust.codegen-backends=llvm,cranelift,gcc', '--set', 'llvm.static-libstdcpp', '--enable-new-symbol-mangling']
configure: target.x86_64-unknown-linux-gnu.llvm-config := /usr/lib/llvm-17/bin/llvm-config
configure: llvm.link-shared     := True
configure: rust.thin-lto-import-instr-limit := 10
configure: change-id            := 99999999
---
failures:

---- [ui] tests/ui/unicode-quote.rs stdout ----

error: /checkout/tests/ui/unicode-quote.rs:2: unexpected error: '2:26: 2:27: unknown character escape: `\u{201c}`'

error: /checkout/tests/ui/unicode-quote.rs:2: unexpected error: '2:32: 2:33: unknown character escape: `\u{201d}`'
error: 2 unexpected errors found, 0 expected errors not found
status: exit status: 1
status: exit status: 1
command: env -u RUSTC_LOG_COLOR RUSTC_ICE="0" RUST_BACKTRACE="short" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/tests/ui/unicode-quote.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=/checkout/vendor" "--sysroot" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2" "--target=x86_64-unknown-linux-gnu" "--check-cfg" "cfg(FALSE)" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zwrite-long-types-to-disk=no" "-Cstrip=debuginfo" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/unicode-quote" "-A" "unused" "-A" "internal_features" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/unicode-quote/auxiliary"
--- unexpected errors (from JSON output) ---
--- unexpected errors (from JSON output) ---
ERROR     line   2: 2:26: 2:27: unknown character escape: `\u{201c}`
ERROR     line   2: 2:32: 2:33: unknown character escape: `\u{201d}`
thread '[ui] tests/ui/unicode-quote.rs' panicked at src/tools/compiletest/src/runtest.rs:1495:13:
errors differ from expected

compiler-errors · 2024-08-10T00:43:13Z

compiler/rustc_parse/src/lexer/unescape_error_reporting.rs

+                    "{ec} is not an ascii quote, \
+                             but may look like one in some fonts.\n\
+                             consider writing it in its \
+                             escaped form for clarity."


the spacing is a bit awkward here. Can we use a semicolon to turn this into one line?

Suggested change

"{ec} is not an ascii quote, \

but may look like one in some fonts.\n\

consider writing it in its \

escaped form for clarity."

"{ec} is not an ascii quote but may look like one in some fonts; consider escaping it to avoid confusion"

i'm pretty sure that would put it over the 100 char line length limit.

i'm also unsure if you have a problem with the formatting of the output or the code (the code is 4 lines, but the actual output is only 2)

The output -- we don't typically have multi-line diagnostics (unless formatting a list or something), and we try to avoid periods in diagnostic outputs as a matter of style. I personally find multi-sentence notes to be a bit wordy.

Yeah, you'll need to re-\ the string literal.

compiler-errors · 2024-08-10T01:38:04Z

Also please squash this into one commit, no need for an additional fmt commit

PatchMixolydic · 2024-08-10T01:39:35Z

I opted not to produce a suggestion, since it's not obvious what the user meant to do.

You could emit a MaybeIncorrect suggestion to replace the quote character with its escaped form. If I remember correctly, this would make the suggestion available to tools that support user intervention (rust-analyzer) while allowing fully automated tools (rustfix) to ignore it. (This would also make the suggested fix super obvious just from glancing at the diagnostic.)

jieyouxu · 2024-08-10T05:06:19Z

tests/ui/unicode-quote.stderr

+   = help: \u{201c} is not an ascii quote, but may look like one in some fonts.
+           consider writing it in its escaped form for clarity.


Suggestion: the help message itself could look like

help: U+201C Left Double Quotation Mark (“) looks like U+0022 Quotation Mark (") (ASCII quotation mark) but are different characters

and a MaybeIncorrect suggestion as mentioned could look something like

help: consider writing the Unicode escape | 2 | dbg!("since when is \u{201c}THIS\” not allowed in a string literal"); | ++++++++

(exact wording may vary)

does rustc have a database of unicode character names?

estebank · 2024-09-02T16:23:40Z

I'm not going to be around for a few weeks. r? @compiler-errors as you were already looking at it :)

Dylan-DPC · 2024-10-28T18:56:48Z

@lolbinarycat any updates on this? thanks

lolbinarycat · 2024-10-28T19:36:23Z

@Dylan-DPC I've mostly moved on to working on rustdoc, since the codebase is smaller and i feel like i can make a more meaningful impact on it. I may come back to this at some point, but if someone else wants to take over this PR, I wouldn't mind.

apiraino · 2025-03-20T12:40:05Z

superseded by #137067

Hint on unknown escape of Unicode quotation marks in string literal

73c88ce

Fixes rust-lang#128858 I opted not to produce a suggestion, since it's not obvious what the user meant to do.

rustbot assigned estebank Aug 9, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 9, 2024

This comment has been minimized.

Sign in to view

fmt

775cb88

compiler-errors reviewed Aug 10, 2024

View reviewed changes

jieyouxu reviewed Aug 10, 2024

View reviewed changes

estebank added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 2, 2024

rustbot assigned compiler-errors and unassigned estebank Sep 2, 2024

alex-semenyuk added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 25, 2024

LFS6502 mentioned this pull request Feb 15, 2025

Hint on unknown escape of Unicode quotation marks in string literal #137067

Open

apiraino closed this Mar 20, 2025

apiraino removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Mar 20, 2025

		= help: \u{201c} is not an ascii quote, but may look like one in some fonts.
		consider writing it in its escaped form for clarity.

Uh oh!

Conversation

lolbinarycat commented Aug 9, 2024

Uh oh!

rustbot commented Aug 9, 2024

Uh oh!

This comment has been minimized.

rust-log-analyzer commented Aug 9, 2024

Uh oh!

compiler-errors Aug 10, 2024

Choose a reason for hiding this comment

Uh oh!

lolbinarycat Aug 10, 2024

Choose a reason for hiding this comment

Uh oh!

compiler-errors Aug 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

compiler-errors commented Aug 10, 2024

Uh oh!

PatchMixolydic commented Aug 10, 2024

Uh oh!

jieyouxu Aug 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lolbinarycat Oct 28, 2024

Choose a reason for hiding this comment

Uh oh!

estebank commented Sep 2, 2024

Uh oh!

Dylan-DPC commented Oct 28, 2024

Uh oh!

lolbinarycat commented Oct 28, 2024

Uh oh!

apiraino commented Mar 20, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

compiler-errors Aug 10, 2024 •

edited

Loading

jieyouxu Aug 10, 2024 •

edited

Loading