Hint on unknown escape of Unicode quotation marks in string literal#137067
Open
LFS6502 wants to merge 6 commits intorust-lang:mainfrom
Open
Hint on unknown escape of Unicode quotation marks in string literal#137067LFS6502 wants to merge 6 commits intorust-lang:mainfrom
LFS6502 wants to merge 6 commits intorust-lang:mainfrom
Conversation
Fixes rust-lang#128858 I opted not to produce a suggestion, since it's not obvious what the user meant to do.
Collaborator
|
r? @wesleywiser rustbot has assigned @wesleywiser. Use |
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
closes #128906 |
Contributor
Author
|
@jieyouxu @compiler-errors @Dylan-DPC If you've got some spare time, I'd love some input from you too. I will squash at the end. |
Contributor
Author
error: unknown character escape: `\u{201c}`
--> src/main.rs:2:26
|
2 | dbg!("since when is \“THIS\” not allowed in a string literal");
| ^ unknown character escape
|
= help: \u{201c} is not an ascii quote, but may look like one in some fonts; consider writing it in its escaped form for clarity.
help: if you meant to use a unicode quote; consider using its escaped form for clarity
|
2 - dbg!("since when is \“THIS\” not allowed in a string literal");
2 + dbg!("since when is \u{201c}THIS\” not allowed in a string literal");
|
error: unknown character escape: `\u{201d}`
--> src/main.rs:2:32
|
2 | dbg!("since when is \“THIS\” not allowed in a string literal");
| ^ unknown character escape
|
= help: \u{201d} is not an ascii quote, but may look like one in some fonts; consider writing it in its escaped form for clarity.
help: if you meant to use a unicode quote; consider using its escaped form for clarity
|
2 - dbg!("since when is \“THIS\” not allowed in a string literal");
2 + dbg!("since when is \“THIS\u{201d} not allowed in a string literal");
|
error: could not compile `diag` (bin "diag") due to 2 previous errorsIn image form: Details
|
LFS6502
added
A-diagnostics
Contributor
|
Assigning review to Michael because of this comment in the previous version of a patch. |
Contributor
|
kinda busy so re-rolling r? compiler |
Noratrieb
reviewed
Mar 24, 2025
Member
Noratrieb
left a comment
Noratrieb
left a comment
There was a problem hiding this comment.
thanks, this looks good overall, some small suggestions, then you can squash it and we can merge it.
I'm not entirely convinced the suggestion is worth it, since it seems really unlikely someone would write this on purpose intending anything other than what the issue author intended. But it's fine to have if you think it's good
| err_span, | ||
| "if you meant to use a unicode quote; \ | ||
| consider using its escaped form for clarity", | ||
| // lit.replace(c, &ec[1..]), |
Member
There was a problem hiding this comment.
looks like this was left over from development
Contributor
There was a problem hiding this comment.
This still needs to be addressed.
Noratrieb
added
S-waiting-on-author
Co-authored-by: nora <48135649+Noratrieb@users.noreply.github.com>
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
estebank
reviewed
Jun 2, 2025
| err_span, | ||
| "if you meant to use a unicode quote; \ | ||
| consider using its escaped form for clarity", | ||
| // lit.replace(c, &ec[1..]), |
Contributor
There was a problem hiding this comment.
This still needs to be addressed.
|
|
||
| diag.help(format!( | ||
| "{ec} is not an ASCII quote, but may look like one in some fonts; \ | ||
| consider writing it in its escaped form for clarity." |
Contributor
There was a problem hiding this comment.
Suggested change
| consider writing it in its escaped form for clarity." | |
| consider writing it in its escaped form for clarity" |
Comment on lines
+162
to
+174
| diag.span_suggestion( | ||
| err_span, | ||
| "if you meant to use a unicode quote; \ | ||
| consider using its escaped form for clarity", | ||
| // lit.replace(c, &ec[1..]), | ||
| &ec, | ||
| Applicability::MaybeIncorrect, | ||
| ); | ||
|
|
||
| diag.help(format!( | ||
| "{ec} is not an ASCII quote, but may look like one in some fonts; \ | ||
| consider writing it in its escaped form for clarity." | ||
| )); |
Contributor
There was a problem hiding this comment.
Instead of emitting both a help and a suggestion, use the message from the help in a span_suggestion_verbose. The text is effectively saying the same thing twice, the help message can have the explanation, that's preferable.
Comment on lines
+315
to
+319
| // list of homoglyphs generated using the following wikidata query: | ||
| // SELECT ?u WHERE { | ||
| // wd:Q87495536 wdt:P2444+ ?c. | ||
| // ?c wdt:P4213 ?u. | ||
| // } |
Contributor
There was a problem hiding this comment.
For future reference, I recall that the unicode tables have a "similarity" field that I've looked at in the past.
Contributor
Author
|
Thanks, working on this now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #128858
Continuation of #128906