Skip to content

Fix is_val_statically_known for floats#129173

Merged
bors merged 1 commit intorust-lang:masterfrom
beetrees:statically-known-float
Aug 18, 2024
Merged

Fix is_val_statically_known for floats#129173
bors merged 1 commit intorust-lang:masterfrom
beetrees:statically-known-float

Conversation

@beetrees
Copy link
Copy Markdown
Contributor

@beetrees beetrees commented Aug 16, 2024

The LLVM intrinsic name for floats differs from the LLVM type name, so handle them explicitly. Also adds support for f16 and f128.

f16/f128 tracking issue: #116909

@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Aug 16, 2024

r? @cjgillot

rustbot has assigned @cjgillot.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 16, 2024
compiler-errors
compiler-errors reviewed Aug 17, 2024
View reviewed changes
compiler/rustc_codegen_llvm/src/intrinsic.rs Outdated
| TypeKind::Float
| TypeKind::Double
| TypeKind::FP128 => {
let type_str = match kind {
Copy link
Copy Markdown
Contributor

@compiler-errors compiler-errors Aug 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This double match is really awkward. I'd honestly rather the code duplication, or maybe make the _ => branch into a return so you can uplift that let type_str out of the outer match. Also worth leaving a note why some of these are special cased.

Copy link
Copy Markdown
Contributor Author

@beetrees beetrees Aug 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've refactored it to be a single match statement.

@beetrees beetrees force-pushed the statically-known-float branch from 1e56969 to 9bc7cea Compare August 17, 2024 01:24
@compiler-errors
Copy link
Copy Markdown
Contributor

compiler-errors commented Aug 17, 2024

@bors r+

@beetrees
Copy link
Copy Markdown
Contributor Author

beetrees commented Aug 17, 2024

Not showing up in the queue.

@bors ping

@compiler-errors
Copy link
Copy Markdown
Contributor

compiler-errors commented Aug 17, 2024

I'll try closing and reopening

@compiler-errors
Copy link
Copy Markdown
Contributor

compiler-errors commented Aug 17, 2024

@bors r+

@bors
Copy link
Copy Markdown
Collaborator

bors commented Aug 17, 2024

📌 Commit 9bc7cea has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 17, 2024
tgross35 added a commit to tgross35/rust that referenced this pull request Aug 17, 2024
@tgross35
Rollup merge of rust-lang#129173 - beetrees:statically-known-float, r…
9c044b5 
…=compiler-errors

Fix `is_val_statically_known` for floats

The LLVM intrinsic name for floats differs from the LLVM type name, so handle them explicitly. Also adds support for `f16` and `f128`.

`f16`/`f128` tracking issue: rust-lang#116909
@tgross35 tgross35 mentioned this pull request Aug 17, 2024
Closed
tgross35 added a commit to tgross35/rust that referenced this pull request Aug 17, 2024
@tgross35
Rollup merge of rust-lang#129173 - beetrees:statically-known-float, r…
d70f8b9 
…=compiler-errors

Fix `is_val_statically_known` for floats

The LLVM intrinsic name for floats differs from the LLVM type name, so handle them explicitly. Also adds support for `f16` and `f128`.

`f16`/`f128` tracking issue: rust-lang#116909
@tgross35 tgross35 mentioned this pull request Aug 17, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 17, 2024
@bors
Auto merge of rust-lang#129198 - tgross35:rollup-bxc17se, r=tgross35
150bacd 
Rollup of 9 pull requests

Successful merges:

 - rust-lang#128786 (Detect multiple crate versions on method not found)
 - rust-lang#128982 (Re-enable more debuginfo tests on Windows)
 - rust-lang#128989 (Emit an error for invalid use of the linkage attribute)
 - rust-lang#129115 (Re-enable `dump-ice-to-disk` for Windows)
 - rust-lang#129164 (Use `ar_archive_writer` for writing COFF import libs on all backends)
 - rust-lang#129167 (mir/pretty: use `Option` instead of `Either<Once, Empty>`)
 - rust-lang#129168 (Return correct HirId when finding body owner in diagnostics)
 - rust-lang#129173 (Fix `is_val_statically_known` for floats)
 - rust-lang#129185 (Port `run-make/libtest-json/validate_json.py` to Rust)

r? `@ghost`
`@rustbot` modify labels: rollup
tgross35 added a commit to tgross35/rust that referenced this pull request Aug 17, 2024
@tgross35
Rollup merge of rust-lang#129173 - beetrees:statically-known-float, r…
8f916ca 
…=compiler-errors

Fix `is_val_statically_known` for floats

The LLVM intrinsic name for floats differs from the LLVM type name, so handle them explicitly. Also adds support for `f16` and `f128`.

`f16`/`f128` tracking issue: rust-lang#116909
@tgross35 tgross35 mentioned this pull request Aug 17, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 17, 2024
@bors
Auto merge of rust-lang#129210 - tgross35:rollup-571noi5, r=tgross35
3560e3c 
Rollup of 6 pull requests

Successful merges:

 - rust-lang#128771 (Stabilize `unsafe_attributes`)
 - rust-lang#128982 (Re-enable more debuginfo tests on Windows)
 - rust-lang#129115 (Re-enable `dump-ice-to-disk` for Windows)
 - rust-lang#129173 (Fix `is_val_statically_known` for floats)
 - rust-lang#129185 (Port `run-make/libtest-json/validate_json.py` to Rust)
 - rust-lang#129190 (Added f16 and f128 to tests/ui/consts/const-float-bits-conv.rs)

r? `@ghost`
`@rustbot` modify labels: rollup
@jieyouxu jieyouxu mentioned this pull request Aug 18, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 18, 2024
@bors
Auto merge of rust-lang#129225 - jieyouxu:rollup-xwtkwgr, r=jieyouxu
7521bda 
Rollup of 5 pull requests

Successful merges:

 - rust-lang#129164 (Use `ar_archive_writer` for writing COFF import libs on all backends)
 - rust-lang#129173 (Fix `is_val_statically_known` for floats)
 - rust-lang#129185 (Port `run-make/libtest-json/validate_json.py` to Rust)
 - rust-lang#129203 (Use cnum for extern crate data key)
 - rust-lang#129221 (Remove JohnTitor from review rotation)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 42b54a9 into rust-lang:master Aug 18, 2024
@rustbot rustbot added this to the 1.82.0 milestone Aug 18, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Aug 18, 2024
@rust-timer
Unrolled build for rust-lang#129173
aa0b880 
Rollup merge of rust-lang#129173 - beetrees:statically-known-float, r=compiler-errors

Fix `is_val_statically_known` for floats

The LLVM intrinsic name for floats differs from the LLVM type name, so handle them explicitly. Also adds support for `f16` and `f128`.

`f16`/`f128` tracking issue: rust-lang#116909
@beetrees beetrees deleted the statically-known-float branch August 27, 2024 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@compiler-errors compiler-errors compiler-errors approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@compiler-errors compiler-errors

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.82.0

Development

Successfully merging this pull request may close these issues.

5 participants

@beetrees @rustbot @compiler-errors @bors @cjgillot