Try to improve error messages involving aliases in the solver#131699
Merged
bors merged 5 commits intorust-lang:masterfrom Oct 16, 2024
Merged
Try to improve error messages involving aliases in the solver#131699bors merged 5 commits intorust-lang:masterfrom
bors merged 5 commits intorust-lang:masterfrom
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
Some changes occurred to the core trait solver cc @rust-lang/initiative-trait-system-refactor |
compiler-errors
commented
Oct 14, 2024
lcnr
reviewed
Oct 15, 2024
compiler/rustc_next_trait_solver/src/solve/normalizes_to/mod.rs
Outdated
Show resolved
Hide resolved
lcnr
reviewed
Oct 15, 2024
compiler/rustc_next_trait_solver/src/solve/normalizes_to/mod.rs
Outdated
Show resolved
Hide resolved
lcnr
reviewed
Oct 15, 2024
tests/ui/traits/negative-bounds/opaque-type-unsatisfied-bound.rs
Outdated
Show resolved
Hide resolved
lcnr
reviewed
Oct 15, 2024
Contributor
lcnr
left a comment
lcnr
left a comment
There was a problem hiding this comment.
nice changes, some nits, then r=me
compiler-errors
force-pushed
the
better-errors-for-projections
branch
from
15ee80a to
6281e9e
Compare
compiler-errors
force-pushed
the
better-errors-for-projections
branch
from
6281e9e to
f956dc2
Compare
Contributor
Author
|
@bors r=lcnr |
Collaborator
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Oct 16, 2024
…projections, r=lcnr Try to improve error messages involving aliases in the solver 1. Treat aliases as rigid only if it may not be defined and it's well formed (i.e. for projections, its trait goal is satisfied). 2. Record goals that are related to alias normalization under a new `GoalKind`, so we can look into them in the `BestObligation` visitor. 3. Try to deduplicate errors due to self types of goals that are un-normalizable aliases. r? lcnr
This was referenced Oct 16, 2024
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 16, 2024
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#130822 (Add `from_ref` and `from_mut` constructors to `core::ptr::NonNull`.) - rust-lang#131381 (Implement edition 2024 match ergonomics restrictions) - rust-lang#131594 (rustdoc: Rename "object safe" to "dyn compatible") - rust-lang#131686 (Add fast-path when computing the default visibility) - rust-lang#131699 (Try to improve error messages involving aliases in the solver) - rust-lang#131757 (Ignore lint-non-snake-case-crate#proc_macro_ on targets without unwind) - rust-lang#131783 (Fix explicit_iter_loop in rustc_serialize) - rust-lang#131788 (Fix mismatched quotation mark) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 16, 2024
Rollup merge of rust-lang#131699 - compiler-errors:better-errors-for-projections, r=lcnr Try to improve error messages involving aliases in the solver 1. Treat aliases as rigid only if it may not be defined and it's well formed (i.e. for projections, its trait goal is satisfied). 2. Record goals that are related to alias normalization under a new `GoalKind`, so we can look into them in the `BestObligation` visitor. 3. Try to deduplicate errors due to self types of goals that are un-normalizable aliases. r? lcnr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GoalKind, so we can look into them in theBestObligationvisitor.r? lcnr