refactor: cleaner check to return None#132261

ChrisCho-H · 2024-10-28T10:53:36Z

It's very nit change. Refactor to shorten verbose check when returning None for backend_feature_name.

rustbot · 2024-10-28T10:53:45Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @compiler-errors (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

@rustbot author: the review is finished, PR author should check the comments and take action accordingly
@rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

compiler/rustc_codegen_llvm/src/llvm_util.rs

compiler-errors · 2024-10-28T14:03:04Z

I guess so

@bors r+ rollup

bors · 2024-10-28T14:03:08Z

📌 Commit 82bfe05 has been approved by compiler-errors

It is now in the queue for this repository.

…none, r=compiler-errors refactor: cleaner check to return None It's very nit change. Refactor to shorten verbose check when returning None for `backend_feature_name`.

…kingjubilee Rollup of 9 pull requests Successful merges: - rust-lang#130259 (Lower AST node id only once) - rust-lang#131441 (Add a new trait `proc_macro::ToTokens`) - rust-lang#132247 (stable_mir: Directly use types from rustc_abi) - rust-lang#132249 (compiler: Add rustc_abi dependence to the compiler) - rust-lang#132255 (Add `LayoutS::is_uninhabited` and use it) - rust-lang#132258 ([rustdoc] Unify variant struct fields margins with struct fields) - rust-lang#132260 (cg_llvm: Use a type-safe helper to cast `&str` and `&[u8]` to `*const c_char`) - rust-lang#132261 (refactor: cleaner check to return None) - rust-lang#132271 (Updating Fuchsia platform-support documentation) r? `@ghost` `@rustbot` modify labels: rollup

…none, r=compiler-errors refactor: cleaner check to return None It's very nit change. Refactor to shorten verbose check when returning None for `backend_feature_name`.

…iaskrgr Rollup of 10 pull requests Successful merges: - rust-lang#130259 (Lower AST node id only once) - rust-lang#131441 (Add a new trait `proc_macro::ToTokens`) - rust-lang#132247 (stable_mir: Directly use types from rustc_abi) - rust-lang#132249 (compiler: Add rustc_abi dependence to the compiler) - rust-lang#132255 (Add `LayoutData::is_uninhabited` and use it) - rust-lang#132258 ([rustdoc] Unify variant struct fields margins with struct fields) - rust-lang#132260 (cg_llvm: Use a type-safe helper to cast `&str` and `&[u8]` to `*const c_char`) - rust-lang#132261 (refactor: cleaner check to return None) - rust-lang#132271 (Updating Fuchsia platform-support documentation) - rust-lang#132295 (fixed wast version was released, remove randomization exemption) r? `@ghost` `@rustbot` modify labels: rollup

…kingjubilee Rollup of 9 pull requests Successful merges: - rust-lang#130259 (Lower AST node id only once) - rust-lang#131441 (Add a new trait `proc_macro::ToTokens`) - rust-lang#132247 (stable_mir: Directly use types from rustc_abi) - rust-lang#132249 (compiler: Add rustc_abi dependence to the compiler) - rust-lang#132255 (Add `LayoutData::is_uninhabited` and use it) - rust-lang#132258 ([rustdoc] Unify variant struct fields margins with struct fields) - rust-lang#132260 (cg_llvm: Use a type-safe helper to cast `&str` and `&[u8]` to `*const c_char`) - rust-lang#132261 (refactor: cleaner check to return None) - rust-lang#132271 (Updating Fuchsia platform-support documentation) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#132261 - ChrisCho-H:refactor/cleaner-check-none, r=compiler-errors refactor: cleaner check to return None It's very nit change. Refactor to shorten verbose check when returning None for `backend_feature_name`.

rustbot assigned compiler-errors Oct 28, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 28, 2024

This comment has been minimized.

Sign in to view

ChrisCho-H force-pushed the refactor/cleaner-check-none branch from 386614b to 9a25ea7 Compare October 28, 2024 11:11

fmease reviewed Oct 28, 2024

View reviewed changes

compiler/rustc_codegen_llvm/src/llvm_util.rs Outdated Show resolved Hide resolved

refactor: cleaner check to return None

82bfe05

ChrisCho-H force-pushed the refactor/cleaner-check-none branch from 9a25ea7 to 82bfe05 Compare October 28, 2024 11:16

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 28, 2024

GuillaumeGomez mentioned this pull request Oct 28, 2024

Rollup of 5 pull requests #132269

Closed

This was referenced Oct 28, 2024

Rollup of 9 pull requests #132273

Closed

Rollup of 9 pull requests #132277

Merged

matthiaskrgr mentioned this pull request Oct 29, 2024

Rollup of 10 pull requests #132307

Closed

workingjubilee mentioned this pull request Oct 29, 2024

Rollup of 12 pull requests #132308

Closed

bors merged commit 6fd4a76 into rust-lang:master Oct 29, 2024

rustbot added this to the 1.84.0 milestone Oct 29, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

refactor: cleaner check to return None#132261