rustc: Always name bytecode based on crate ids#13321
Closed
alexcrichton wants to merge 1 commit intorust-lang:masterfrom
Closed
rustc: Always name bytecode based on crate ids#13321alexcrichton wants to merge 1 commit intorust-lang:masterfrom
alexcrichton wants to merge 1 commit intorust-lang:masterfrom
Conversation
When performing LTO, bytecode is loaded from an archive by using the crate id's name. If the -o flag was specified when building the original library, it previously also mangled the name of the bytecode. This switches to always using the crate id's name when naming the bytecode file, ensuring that it can always be loaded at a later date, regardless of -o. Closes rust-lang#13317
Contributor
|
r+ |
Contributor
|
travis failed due to a missing license issue |
Member
Author
|
There's a more subtle bug going on, I'll try to get around to this later. |
Contributor
|
Should this issue be reopened? The -o option still seems to be breaking LTO. (i.e. With a crate named foo, |
Contributor
|
I guess it wouldn't make sense to "reopen" this, because it's a pull request. Maybe file a report? |
matthiaskrgr
pushed a commit
to matthiaskrgr/rust
that referenced
this pull request
Oct 11, 2022
Fix move_format_string_arg being tokentree unaware Fixes rust-lang/rust-analyzer#13261
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 24, 2024
…rednet Make it clearer that the suggestion is an alternative one `needless_pass_by_value` sometimes suggest marking the concerned type as `Copy`. Adding a `or` before this suggestion makes it clearer that this is not the second part of the original suggestion, but an alternative one. Inspired by a misunderstanding in rust-lang#13321 changelog: none
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When performing LTO, bytecode is loaded from an archive by using the crate id's
name. If the -o flag was specified when building the original library, it
previously also mangled the name of the bytecode.
This switches to always using the crate id's name when naming the bytecode file,
ensuring that it can always be loaded at a later date, regardless of -o.
Closes #13317