Stabilize substr_range and subslice_range#141266
Open
wr7 wants to merge 1 commit intorust-lang:mainfrom
Open
Conversation
Collaborator
rustbot
added
S-waiting-on-review
8 tasks
Member
|
r? libs-api (needs fcp) |
rustbot
added
the
T-libs-api
jieyouxu
added
needs-fcp
Contributor
|
Nominating to discuss possible stabilization. Please see the report at #126769 (comment), and some followup discussion there about API and naming. @rustbot label +I-libs-api-nominated |
rustbot
added
I-libs-api-nominated
Amanieu
removed
the
I-libs-api-nominated
ibraheemdev
removed
the
S-waiting-on-review
Member
|
r? libs-api |
ibraheemdev
added
the
S-waiting-on-review
wr7
force-pushed
the
stabilize_substr_range
branch
from
ecd3bb0 to
2c58efe
Compare
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
@the8472 The FCP has ended. This should be ready to merge AFAIK |
Collaborator
|
Error: Label finished-final-comment-period can only be set by Rust team members Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #triagebot on Zulip. |
Contributor
|
Last minute concern about the range types used #126769 (comment). |
Contributor
|
☔ The latest upstream changes (presumably #150798) made this pull request unmergeable. Please resolve the merge conflicts. |
wr7
force-pushed
the
stabilize_substr_range
branch
from
2c58efe to
0ab4250
Compare
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Apr 4, 2026
…rk-Simulacrum Make `substr_range` and `subslice_range` return the new `Range` type Makes the unstable `substr_slice` and `substr_range` functions return the new `core::range::Range` type, instead of the old `core::ops::Range`. Unblocks the [stabilization](rust-lang#141266) of `#![feature(substr_range)]`, see rust-lang#141266 (comment)
rust-timer
added a commit
that referenced
this pull request
Apr 5, 2026
Rollup merge of #154707 - nik-contrib:substr-new-range, r=Mark-Simulacrum Make `substr_range` and `subslice_range` return the new `Range` type Makes the unstable `substr_slice` and `substr_range` functions return the new `core::range::Range` type, instead of the old `core::ops::Range`. Unblocks the [stabilization](#141266) of `#![feature(substr_range)]`, see #141266 (comment)
This comment has been minimized.
This comment has been minimized.
Contributor
|
Re-nominated for discussion #126769 (comment). @wr7 could you rebase? |
github-actions bot
pushed a commit
to rust-lang/miri
that referenced
this pull request
Apr 5, 2026
…crum Make `substr_range` and `subslice_range` return the new `Range` type Makes the unstable `substr_slice` and `substr_range` functions return the new `core::range::Range` type, instead of the old `core::ops::Range`. Unblocks the [stabilization](rust-lang/rust#141266) of `#![feature(substr_range)]`, see rust-lang/rust#141266 (comment)
wr7
force-pushed
the
stabilize_substr_range
branch
from
0ab4250 to
a6eebbe
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Contributor
Author
|
Rebased |
wr7
changed the title
substr_range and related methodssubstr_range and subslice_range
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #126769
Stabilization Report
Finished FCP