Skip to content

Refactor Translator#142650

Merged
bors merged 3 commits intorust-lang:masterfrom
camsteffen:refactor-translator
Jun 21, 2025
Merged

Refactor Translator#142650
bors merged 3 commits intorust-lang:masterfrom
camsteffen:refactor-translator

Conversation

@camsteffen
Copy link
Copy Markdown
Contributor

@camsteffen camsteffen commented Jun 17, 2025 •
edited
Loading

My main motivation was to simplify the usage of SilentEmitter for users like rustfmt. A few refactoring opportunities arose along the way.

  • Replace Translate trait with Translator struct
  • Replace Emitter: Translate with Emitter::translator
  • Split SilentEmitter into FatalOnlyEmitter and SilentEmitter

@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Jun 17, 2025

r? @petrochenkov

rustbot has assigned @petrochenkov.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Jun 17, 2025
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Jun 17, 2025

Some changes occurred in compiler/rustc_codegen_ssa

cc @WaffleLapkin

rustc_errors::translation was changed

cc @davidtwco, @compiler-errors, @TaKO8Ki

rustc_error_messages was changed

cc @davidtwco, @compiler-errors, @TaKO8Ki

Some changes occurred in src/tools/rustfmt

cc @rust-lang/rustfmt

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

@petrochenkov
Copy link
Copy Markdown
Contributor

petrochenkov commented Jun 18, 2025

Looks reasonable to me.
@bors r+

@bors
Copy link
Copy Markdown
Collaborator

bors commented Jun 18, 2025

📌 Commit 4a86853 has been approved by petrochenkov

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 18, 2025
bjorn3
bjorn3 reviewed Jun 18, 2025
View reviewed changes
@bjorn3
Copy link
Copy Markdown
Member

bjorn3 commented Jun 19, 2025

(bors forgot to post a comment about the merge conflicts)

@petrochenkov
Copy link
Copy Markdown
Contributor

petrochenkov commented Jun 19, 2025

@bors r-
@rustbot author

@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Jun 19, 2025

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@rustbot rustbot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jun 19, 2025
@bors bors removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jun 19, 2025
@camsteffen camsteffen force-pushed the refactor-translator branch from 4a86853 to 3388d83 Compare June 19, 2025 18:07
@camsteffen
Copy link
Copy Markdown
Contributor Author

camsteffen commented Jun 19, 2025 •
edited
Loading

Rebased and renamed to FatalOnlyEmitter. @rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 19, 2025
@petrochenkov
Copy link
Copy Markdown
Contributor

petrochenkov commented Jun 19, 2025

@bors r+

@bors
Copy link
Copy Markdown
Collaborator

bors commented Jun 19, 2025

📌 Commit 3388d83 has been approved by petrochenkov

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 19, 2025
@tgross35 tgross35 mentioned this pull request Jun 20, 2025
Merged
bors added a commit that referenced this pull request Jun 20, 2025
@bors
Auto merge of #142794 - tgross35:rollup-iae7okj, r=tgross35
710a45d 
Rollup of 9 pull requests

Successful merges:

 - #142331 (Add `trim_prefix` and `trim_suffix` methods for both `slice` and `str` types.)
 - #142491 (Rework #[cold] attribute parser)
 - #142494 (Fix missing docs in `rustc_attr_parsing`)
 - #142495 (Better template for `#[repr]` attributes)
 - #142497 (Fix random failure when JS code is executed when the whole file was not read yet)
 - #142575 (Ensure copy* intrinsics also perform the static self-init checks)
 - #142650 (Refactor Translator)
 - #142713 (mbe: Refactor transcription)
 - #142755 (rustdoc: Remove `FormatRenderer::cache`)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit that referenced this pull request Jun 20, 2025
@bors
Auto merge of #142794 - tgross35:rollup-iae7okj, r=tgross35
15c701f 
Rollup of 9 pull requests

Successful merges:

 - #142331 (Add `trim_prefix` and `trim_suffix` methods for both `slice` and `str` types.)
 - #142491 (Rework #[cold] attribute parser)
 - #142494 (Fix missing docs in `rustc_attr_parsing`)
 - #142495 (Better template for `#[repr]` attributes)
 - #142497 (Fix random failure when JS code is executed when the whole file was not read yet)
 - #142575 (Ensure copy* intrinsics also perform the static self-init checks)
 - #142650 (Refactor Translator)
 - #142713 (mbe: Refactor transcription)
 - #142755 (rustdoc: Remove `FormatRenderer::cache`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 38600a6 into rust-lang:master Jun 21, 2025
10 checks passed
@rustbot rustbot added this to the 1.89.0 milestone Jun 21, 2025
rust-timer added a commit that referenced this pull request Jun 21, 2025
@rust-timer
Unrolled build for #142650
62dadd2 
Rollup merge of #142650 - camsteffen:refactor-translator, r=petrochenkov

Refactor Translator

My main motivation was to simplify the usage of `SilentEmitter` for users like rustfmt. A few refactoring opportunities arose along the way.

* Replace `Translate` trait with `Translator` struct
* Replace `Emitter: Translate` with `Emitter::translator`
* Split `SilentEmitter` into `FatalOnlyEmitter` and `SilentEmitter`
@camsteffen camsteffen deleted the refactor-translator branch June 21, 2025 11:05
github-actions bot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Jun 23, 2025
@bors
Auto merge of #142794 - tgross35:rollup-iae7okj, r=tgross35
f13e313 
Rollup of 9 pull requests

Successful merges:

 - rust-lang/rust#142331 (Add `trim_prefix` and `trim_suffix` methods for both `slice` and `str` types.)
 - rust-lang/rust#142491 (Rework #[cold] attribute parser)
 - rust-lang/rust#142494 (Fix missing docs in `rustc_attr_parsing`)
 - rust-lang/rust#142495 (Better template for `#[repr]` attributes)
 - rust-lang/rust#142497 (Fix random failure when JS code is executed when the whole file was not read yet)
 - rust-lang/rust#142575 (Ensure copy* intrinsics also perform the static self-init checks)
 - rust-lang/rust#142650 (Refactor Translator)
 - rust-lang/rust#142713 (mbe: Refactor transcription)
 - rust-lang/rust#142755 (rustdoc: Remove `FormatRenderer::cache`)

r? `@ghost`
`@rustbot` modify labels: rollup
@Distortedlogic Distortedlogic mentioned this pull request Jun 25, 2025
Closed
flip1995 pushed a commit to flip1995/rust-clippy that referenced this pull request Jun 26, 2025
@bors
Auto merge of #142794 - tgross35:rollup-iae7okj, r=tgross35
f53cd2b 
Rollup of 9 pull requests

Successful merges:

 - rust-lang/rust#142331 (Add `trim_prefix` and `trim_suffix` methods for both `slice` and `str` types.)
 - rust-lang/rust#142491 (Rework #[cold] attribute parser)
 - rust-lang/rust#142494 (Fix missing docs in `rustc_attr_parsing`)
 - rust-lang/rust#142495 (Better template for `#[repr]` attributes)
 - rust-lang/rust#142497 (Fix random failure when JS code is executed when the whole file was not read yet)
 - rust-lang/rust#142575 (Ensure copy* intrinsics also perform the static self-init checks)
 - rust-lang/rust#142650 (Refactor Translator)
 - rust-lang/rust#142713 (mbe: Refactor transcription)
 - rust-lang/rust#142755 (rustdoc: Remove `FormatRenderer::cache`)

r? `@ghost`
`@rustbot` modify labels: rollup
flip1995 pushed a commit to flip1995/rust that referenced this pull request Jun 26, 2025
@tgross35
Rollup merge of rust-lang#142650 - camsteffen:refactor-translator, r=…
5f759a9 
…petrochenkov

Refactor Translator

My main motivation was to simplify the usage of `SilentEmitter` for users like rustfmt. A few refactoring opportunities arose along the way.

* Replace `Translate` trait with `Translator` struct
* Replace `Emitter: Translate` with `Emitter::translator`
* Split `SilentEmitter` into `FatalOnlyEmitter` and `SilentEmitter`
@tautschnig tautschnig mentioned this pull request Jun 27, 2025
Merged
tautschnig added a commit to tautschnig/kani that referenced this pull request Jun 27, 2025
@tautschnig
Upgrade Rust toolchain to 2025-06-27
b17f7ff 
Relevant upstream PRs:
- rust-lang/rust#141061 (Change
  __rust_no_alloc_shim_is_unstable to be a function)
- rust-lang/rust#142650 (Refactor Translator)

Resolves: model-checking#4176
github-merge-queue bot pushed a commit to model-checking/kani that referenced this pull request Jun 27, 2025
@tautschnig
Upgrade Rust toolchain to 2025-06-27 (#4182)
79fe8af 
Relevant upstream PRs:
- rust-lang/rust#141061 (Change
  __rust_no_alloc_shim_is_unstable to be a function)
- rust-lang/rust#142650 (Refactor Translator)

Resolves: #4176

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 and MIT licenses.
tautschnig pushed a commit to model-checking/verify-rust-std that referenced this pull request Jul 3, 2025
@bors
Auto merge of rust-lang#142794 - tgross35:rollup-iae7okj, r=tgross35
6f6900e 
Rollup of 9 pull requests

Successful merges:

 - rust-lang#142331 (Add `trim_prefix` and `trim_suffix` methods for both `slice` and `str` types.)
 - rust-lang#142491 (Rework #[cold] attribute parser)
 - rust-lang#142494 (Fix missing docs in `rustc_attr_parsing`)
 - rust-lang#142495 (Better template for `#[repr]` attributes)
 - rust-lang#142497 (Fix random failure when JS code is executed when the whole file was not read yet)
 - rust-lang#142575 (Ensure copy* intrinsics also perform the static self-init checks)
 - rust-lang#142650 (Refactor Translator)
 - rust-lang#142713 (mbe: Refactor transcription)
 - rust-lang#142755 (rustdoc: Remove `FormatRenderer::cache`)

r? `@ghost`
`@rustbot` modify labels: rollup
mohe2015 pushed a commit to tucan-plus/rustfmt that referenced this pull request Sep 6, 2025
@bors
Auto merge of #142794 - tgross35:rollup-iae7okj, r=tgross35
8cf8b25 
Rollup of 9 pull requests

Successful merges:

 - rust-lang/rust#142331 (Add `trim_prefix` and `trim_suffix` methods for both `slice` and `str` types.)
 - rust-lang/rust#142491 (Rework #[cold] attribute parser)
 - rust-lang/rust#142494 (Fix missing docs in `rustc_attr_parsing`)
 - rust-lang/rust#142495 (Better template for `#[repr]` attributes)
 - rust-lang/rust#142497 (Fix random failure when JS code is executed when the whole file was not read yet)
 - rust-lang/rust#142575 (Ensure copy* intrinsics also perform the static self-init checks)
 - rust-lang/rust#142650 (Refactor Translator)
 - rust-lang/rust#142713 (mbe: Refactor transcription)
 - rust-lang/rust#142755 (rustdoc: Remove `FormatRenderer::cache`)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bjorn3 bjorn3 bjorn3 left review comments

Assignees

@petrochenkov petrochenkov

Labels

A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.89.0

Development

Successfully merging this pull request may close these issues.

5 participants

@camsteffen @rustbot @petrochenkov @bors @bjorn3