Use crosstool-ng for dist-arm-linux-musl#143763
Use crosstool-ng for dist-arm-linux-musl#143763Gelbpunkt wants to merge 1 commit intorust-lang:mainfrom
Conversation
Almost all of the musl dist jobs use crosstool-ng, only the aarch64 and x86_64 jobs use musl-cross-make. Let's start transitioning the remaining jobs over to crosstool-ng and start dropping musl-cross-make. Signed-off-by: Jens Reidel <adrian@travitia.xyz>
|
r? @marcoieni rustbot has assigned @marcoieni. Use |
|
I think you can just rename it (together with the corresponding docker image). You can do it in another PR, too. I'm reviewing the PR 👀 |
| CT_ARCH_ARCH="armv6" | ||
| CT_ARCH_FLOAT_SW=y | ||
| CT_ARCH_64=y | ||
| # CT_DEMULTILIB is not set |
There was a problem hiding this comment.
should we explain why this is not set? 🤔
|
@bors try |
Use crosstool-ng for dist-arm-linux-musl Almost all of the musl dist jobs use crosstool-ng, only the aarch64 and x86_64 jobs use musl-cross-make. Let's start transitioning the remaining jobs over to crosstool-ng and start dropping musl-cross-make. I noticed that this job is called `dist-arm-linux-musl`, but the GNU pendant is called `dist-aarch64-linux`. How would I go about renaming `dist-arm-linux-musl` to `dist-aarch64-linux-musl`? Is there any external effort required or can I just rename it in the repo? try-job: dist-arm-linux-musl
|
☀️ Try build successful - checks-actions |
|
I downloaded the try build artifacts and compared them with the auto build artifacts from the last commit on master.
Is this size increase expected? |
|
Seems a bit weird. I downloaded them and at first glance, only the rustc binary is a tiny bit larger indeed. autobuild:
try-build:
I have a feeling that this is related to the changed CFLAGS. |
Almost all of the musl dist jobs use crosstool-ng, only the aarch64 and x86_64 jobs use musl-cross-make. Let's start transitioning the remaining jobs over to crosstool-ng and start dropping musl-cross-make.
I noticed that this job is called
dist-arm-linux-musl, but the GNU pendant is calleddist-aarch64-linux. How would I go about renamingdist-arm-linux-musltodist-aarch64-linux-musl? Is there any external effort required or can I just rename it in the repo?try-job: dist-arm-linux-musl