Skip to content

Stabilize duration_constructors_lite feature#145135

Merged
bors merged 1 commit intorust-lang:masterfrom
Kivooeo:stabilize-duration_constructors_lite
Aug 10, 2025
Merged

Stabilize duration_constructors_lite feature#145135
bors merged 1 commit intorust-lang:masterfrom
Kivooeo:stabilize-duration_constructors_lite

Conversation

@Kivooeo
Copy link
Copy Markdown
Member

@Kivooeo Kivooeo commented Aug 8, 2025

This closes tracking issue and stabilises Duration::from_hours and Duration::from_mins while not touching a duration_constructors feature from the related tracking issue (2)

@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Aug 8, 2025

r? @jhpratt

rustbot has assigned @jhpratt.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Aug 8, 2025
@Kivooeo
Copy link
Copy Markdown
Member Author

Kivooeo commented Aug 8, 2025

This might be correct to assign someone from T-libs-api rather than T-libs, so hope that noone minds me doing this?

r? libs-api

@rustbot rustbot added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Aug 8, 2025
@rustbot rustbot assigned m-ou-se and unassigned jhpratt Aug 8, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Kivooeo Kivooeo force-pushed the stabilize-duration_constructors_lite branch from 0336500 to 13a4919 Compare August 8, 2025 23:44
@rust-log-analyzer

This comment has been minimized.

Sign in to view
ChrisDenton
ChrisDenton reviewed Aug 9, 2025
View reviewed changes
@ChrisDenton
Copy link
Copy Markdown
Member

ChrisDenton commented Aug 9, 2025

This has passed libs-api FCP so it just needs a libs review and doesn't need any further involvement from libs-api.

@ChrisDenton ChrisDenton assigned ChrisDenton and unassigned m-ou-se Aug 9, 2025
@Kivooeo Kivooeo force-pushed the stabilize-duration_constructors_lite branch from 13a4919 to b5e2ba6 Compare August 9, 2025 08:31
@ChrisDenton
Copy link
Copy Markdown
Member

ChrisDenton commented Aug 9, 2025

Thanks!

@bors r+ rollup

@bors
Copy link
Copy Markdown
Collaborator

bors commented Aug 9, 2025

📌 Commit b5e2ba6 has been approved by ChrisDenton

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 9, 2025
Zalathar added a commit to Zalathar/rust that referenced this pull request Aug 9, 2025
@Zalathar
Rollup merge of rust-lang#145135 - Kivooeo:stabilize-duration_constru…
48e2608 
…ctors_lite, r=ChrisDenton

Stabilize `duration_constructors_lite` feature

This closes [tracking issue](rust-lang#140881) and stabilises `Duration::from_hours` and `Duration::from_mins` while not touching a `duration_constructors` feature from the related [tracking issue (2)](rust-lang#120301)
Zalathar added a commit to Zalathar/rust that referenced this pull request Aug 9, 2025
@Zalathar
Rollup merge of rust-lang#145135 - Kivooeo:stabilize-duration_constru…
4f8f12b 
…ctors_lite, r=ChrisDenton

Stabilize `duration_constructors_lite` feature

This closes [tracking issue](rust-lang#140881) and stabilises `Duration::from_hours` and `Duration::from_mins` while not touching a `duration_constructors` feature from the related [tracking issue (2)](rust-lang#120301)
@Zalathar Zalathar mentioned this pull request Aug 9, 2025
Closed
bors added a commit that referenced this pull request Aug 9, 2025
@bors
Auto merge of #145161 - Zalathar:rollup-uyqbw90, r=Zalathar
33792e0 
Rollup of 8 pull requests

Successful merges:

 - #144739 (Use new public libtest `ERROR_EXIT_CODE` constant in rustdoc)
 - #145089 (Improve error output when a command fails in bootstrap)
 - #145112 ([win][arm64ec] Partial fix for raw-dylib-link-ordinal on Arm64EC)
 - #145135 (Stabilize `duration_constructors_lite` feature)
 - #145146 (remove `P`)
 - #145152 (Use `to_ascii_lowercase` to avoid heap alloc in `detect_confuse_type`)
 - #145156 (Override custom Cargo `build-dir` in bootstrap)
 - #145160 (Change days-threshold to 28 in [behind-upstream])

Failed merges:

 - #145145 (some `derive_more` refactors)

r? `@ghost`
`@rustbot` modify labels: rollup
Zalathar added a commit to Zalathar/rust that referenced this pull request Aug 10, 2025
@Zalathar
Rollup merge of rust-lang#145135 - Kivooeo:stabilize-duration_constru…
8c58da3 
…ctors_lite, r=ChrisDenton

Stabilize `duration_constructors_lite` feature

This closes [tracking issue](rust-lang#140881) and stabilises `Duration::from_hours` and `Duration::from_mins` while not touching a `duration_constructors` feature from the related [tracking issue (2)](rust-lang#120301)
@Zalathar Zalathar mentioned this pull request Aug 10, 2025
Closed
Zalathar added a commit to Zalathar/rust that referenced this pull request Aug 10, 2025
@Zalathar
Rollup merge of rust-lang#145135 - Kivooeo:stabilize-duration_constru…
a3d31bf 
…ctors_lite, r=ChrisDenton

Stabilize `duration_constructors_lite` feature

This closes [tracking issue](rust-lang#140881) and stabilises `Duration::from_hours` and `Duration::from_mins` while not touching a `duration_constructors` feature from the related [tracking issue (2)](rust-lang#120301)
Zalathar added a commit to Zalathar/rust that referenced this pull request Aug 10, 2025
@Zalathar
Rollup merge of rust-lang#145135 - Kivooeo:stabilize-duration_constru…
2d0fcd7 
…ctors_lite, r=ChrisDenton

Stabilize `duration_constructors_lite` feature

This closes [tracking issue](rust-lang#140881) and stabilises `Duration::from_hours` and `Duration::from_mins` while not touching a `duration_constructors` feature from the related [tracking issue (2)](rust-lang#120301)
@Zalathar Zalathar mentioned this pull request Aug 10, 2025
Closed
Zalathar added a commit to Zalathar/rust that referenced this pull request Aug 10, 2025
@Zalathar
Rollup merge of rust-lang#145135 - Kivooeo:stabilize-duration_constru…
14a3afc 
…ctors_lite, r=ChrisDenton

Stabilize `duration_constructors_lite` feature

This closes [tracking issue](rust-lang#140881) and stabilises `Duration::from_hours` and `Duration::from_mins` while not touching a `duration_constructors` feature from the related [tracking issue (2)](rust-lang#120301)
@Zalathar Zalathar mentioned this pull request Aug 10, 2025
Closed
bors added a commit that referenced this pull request Aug 10, 2025
@bors
Auto merge of #145197 - Zalathar:rollup-9a642pd, r=Zalathar
ba1a4f0 
Rollup of 19 pull requests

Successful merges:

 - #141624 (unstable-book: Add stubs for environment variables; document some of the important ones)
 - #143093 (Simplify polonius location-sensitive analysis)
 - #144402 (Stabilize loongarch32 inline asm)
 - #144403 (`tests/ui/issues/`: The Issues Strike Back [4/N])
 - #144544 (Start reporting future breakage for `ILL_FORMED_ATTRIBUTE_INPUT` in dependencies)
 - #144739 (Use new public libtest `ERROR_EXIT_CODE` constant in rustdoc)
 - #145089 (Improve error output when a command fails in bootstrap)
 - #145112 ([win][arm64ec] Partial fix for raw-dylib-link-ordinal on Arm64EC)
 - #145129 ([win][arm64ec] Add `/machine:arm64ec` when linking LLVM as Arm64EC)
 - #145130 (improve "Documentation problem" issue template.)
 - #145135 (Stabilize `duration_constructors_lite` feature)
 - #145145 (some `derive_more` refactors)
 - #145147 (rename `TraitRef::from_method` to `from_assoc`)
 - #145156 (Override custom Cargo `build-dir` in bootstrap)
 - #145160 (Change days-threshold to 28 in [behind-upstream])
 - #145162 (`{BTree,Hash}Map`: add "`Entry` API" section heading)
 - #145175 (Enable limit_rdylib_exports on Solaris)
 - #145187 (Fix an unstable feature comment that wasn't a doc comment)
 - #145191 (`suggest_borrow_generic_arg`: use the correct generic args)

r? `@ghost`
`@rustbot` modify labels: rollup
Zalathar added a commit to Zalathar/rust that referenced this pull request Aug 10, 2025
@Zalathar
Rollup merge of rust-lang#145135 - Kivooeo:stabilize-duration_constru…
78688ee 
…ctors_lite, r=ChrisDenton

Stabilize `duration_constructors_lite` feature

This closes [tracking issue](rust-lang#140881) and stabilises `Duration::from_hours` and `Duration::from_mins` while not touching a `duration_constructors` feature from the related [tracking issue (2)](rust-lang#120301)
@Zalathar Zalathar mentioned this pull request Aug 10, 2025
Closed
bors added a commit that referenced this pull request Aug 10, 2025
@bors
Auto merge of #145204 - Zalathar:rollup-eyrrf5y, r=Zalathar
b6f3e72 
Rollup of 18 pull requests

Successful merges:

 - #141624 (unstable-book: Add stubs for environment variables; document some of the important ones)
 - #143093 (Simplify polonius location-sensitive analysis)
 - #144402 (Stabilize loongarch32 inline asm)
 - #144403 (`tests/ui/issues/`: The Issues Strike Back [4/N])
 - #144739 (Use new public libtest `ERROR_EXIT_CODE` constant in rustdoc)
 - #145089 (Improve error output when a command fails in bootstrap)
 - #145112 ([win][arm64ec] Partial fix for raw-dylib-link-ordinal on Arm64EC)
 - #145129 ([win][arm64ec] Add `/machine:arm64ec` when linking LLVM as Arm64EC)
 - #145130 (improve "Documentation problem" issue template.)
 - #145135 (Stabilize `duration_constructors_lite` feature)
 - #145145 (some `derive_more` refactors)
 - #145147 (rename `TraitRef::from_method` to `from_assoc`)
 - #145156 (Override custom Cargo `build-dir` in bootstrap)
 - #145160 (Change days-threshold to 28 in [behind-upstream])
 - #145162 (`{BTree,Hash}Map`: add "`Entry` API" section heading)
 - #145175 (Enable limit_rdylib_exports on Solaris)
 - #145187 (Fix an unstable feature comment that wasn't a doc comment)
 - #145191 (`suggest_borrow_generic_arg`: use the correct generic args)

r? `@ghost`
`@rustbot` modify labels: rollup
@Zalathar Zalathar mentioned this pull request Aug 10, 2025
Merged
bors added a commit that referenced this pull request Aug 10, 2025
@bors
Auto merge of #145210 - Zalathar:rollup-dm4reb2, r=Zalathar
80ff75f 
Rollup of 17 pull requests

Successful merges:

 - #141624 (unstable-book: Add stubs for environment variables; document some of the important ones)
 - #143093 (Simplify polonius location-sensitive analysis)
 - #144402 (Stabilize loongarch32 inline asm)
 - #144403 (`tests/ui/issues/`: The Issues Strike Back [4/N])
 - #144739 (Use new public libtest `ERROR_EXIT_CODE` constant in rustdoc)
 - #145089 (Improve error output when a command fails in bootstrap)
 - #145112 ([win][arm64ec] Partial fix for raw-dylib-link-ordinal on Arm64EC)
 - #145129 ([win][arm64ec] Add `/machine:arm64ec` when linking LLVM as Arm64EC)
 - #145130 (improve "Documentation problem" issue template.)
 - #145135 (Stabilize `duration_constructors_lite` feature)
 - #145145 (some `derive_more` refactors)
 - #145147 (rename `TraitRef::from_method` to `from_assoc`)
 - #145156 (Override custom Cargo `build-dir` in bootstrap)
 - #145160 (Change days-threshold to 28 in [behind-upstream])
 - #145162 (`{BTree,Hash}Map`: add "`Entry` API" section heading)
 - #145187 (Fix an unstable feature comment that wasn't a doc comment)
 - #145191 (`suggest_borrow_generic_arg`: use the correct generic args)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit that referenced this pull request Aug 10, 2025
@bors
Auto merge of #145210 - Zalathar:rollup-dm4reb2, r=Zalathar
18eeac0 
Rollup of 17 pull requests

Successful merges:

 - #141624 (unstable-book: Add stubs for environment variables; document some of the important ones)
 - #143093 (Simplify polonius location-sensitive analysis)
 - #144402 (Stabilize loongarch32 inline asm)
 - #144403 (`tests/ui/issues/`: The Issues Strike Back [4/N])
 - #144739 (Use new public libtest `ERROR_EXIT_CODE` constant in rustdoc)
 - #145089 (Improve error output when a command fails in bootstrap)
 - #145112 ([win][arm64ec] Partial fix for raw-dylib-link-ordinal on Arm64EC)
 - #145129 ([win][arm64ec] Add `/machine:arm64ec` when linking LLVM as Arm64EC)
 - #145130 (improve "Documentation problem" issue template.)
 - #145135 (Stabilize `duration_constructors_lite` feature)
 - #145145 (some `derive_more` refactors)
 - #145147 (rename `TraitRef::from_method` to `from_assoc`)
 - #145156 (Override custom Cargo `build-dir` in bootstrap)
 - #145160 (Change days-threshold to 28 in [behind-upstream])
 - #145162 (`{BTree,Hash}Map`: add "`Entry` API" section heading)
 - #145187 (Fix an unstable feature comment that wasn't a doc comment)
 - #145191 (`suggest_borrow_generic_arg`: use the correct generic args)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit c15c2f0 into rust-lang:master Aug 10, 2025
10 checks passed
@rustbot rustbot added this to the 1.91.0 milestone Aug 10, 2025
rust-timer added a commit that referenced this pull request Aug 10, 2025
@rust-timer
Unrolled build for #145135
2226b2a 
Rollup merge of #145135 - Kivooeo:stabilize-duration_constructors_lite, r=ChrisDenton

Stabilize `duration_constructors_lite` feature

This closes [tracking issue](#140881) and stabilises `Duration::from_hours` and `Duration::from_mins` while not touching a `duration_constructors` feature from the related [tracking issue (2)](#120301)
@Dietr1ch
Copy link
Copy Markdown
Contributor

Dietr1ch commented Aug 10, 2025

Thanks for picking this up!

I thought it was blocked on rust-team members and that this last change was grabbed by some release cutting automation.

github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request Aug 13, 2025
@Zalathar
Rollup merge of rust-lang#145135 - Kivooeo:stabilize-duration_constru…
e6bca6d 
…ctors_lite, r=ChrisDenton

Stabilize `duration_constructors_lite` feature

This closes [tracking issue](rust-lang#140881) and stabilises `Duration::from_hours` and `Duration::from_mins` while not touching a `duration_constructors` feature from the related [tracking issue (2)](rust-lang#120301)
@BoxyUwU BoxyUwU mentioned this pull request Aug 19, 2025
Closed
3 tasks
@janvhs janvhs mentioned this pull request Mar 24, 2026
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChrisDenton ChrisDenton ChrisDenton left review comments

Assignees

@ChrisDenton ChrisDenton

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.91.0

Development

Successfully merging this pull request may close these issues.

Tracking Issue for duration_constructors_lite

8 participants

@Kivooeo @rustbot @rust-log-analyzer @ChrisDenton @bors @Dietr1ch @m-ou-se @jhpratt