builtin Fn-trait impls: instantiate binder before the return type Sized check#147152
Merged
bors merged 3 commits intorust-lang:masterfrom Sep 30, 2025
Merged
builtin Fn-trait impls: instantiate binder before the return type Sized check#147152bors merged 3 commits intorust-lang:masterfrom
Fn-trait impls: instantiate binder before the return type Sized check#147152bors merged 3 commits intorust-lang:masterfrom
Conversation
rustbot
added
S-waiting-on-review
lcnr
commented
Sep 29, 2025
| // input. | ||
| fn flat_map<T, F, I, G>(_: F, _: G) | ||
| where | ||
| F: FnOnce(T) -> I, |
Contributor
Author
There was a problem hiding this comment.
previously we had to prove for<'a> opaque<'a>: Sized here and each time we tried to prove it resulted in a new opaque<'!a_placeholderN> = ?unconstrained use of the opaque.
This then caused try_evaluate_added_goals to overflow
Contributor
Author
|
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
rust-bors bot
added a commit
that referenced
this pull request
Sep 29, 2025
builtin `Fn`-trait impls: instantiate binder before the return type `Sized` check
This comment has been minimized.
This comment has been minimized.
rustbot
added
the
S-waiting-on-perf
to avoid overflow from proving `for<'a> opaque<'a>: Sized`
lcnr
force-pushed
the
instantiate-pre-sized-check
branch
from
2801aa4 to
07806a1
Compare
Contributor
This comment has been minimized.
This comment has been minimized.
Member
|
r=me if perf good |
BoxyUwU
added
S-waiting-on-author
Collaborator
|
Finished benchmarking commit (00ddbc8): comparison URL. Overall result: no relevant changes - no action neededBenchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf. @bors rollup=never Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesResults (secondary 2.7%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 470.851s -> 469.909s (-0.20%) |
rustbot
removed
the
S-waiting-on-perf
Contributor
Author
|
@bors r=BoxyUwU rollup |
Collaborator
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Sep 30, 2025
Rollup of 4 pull requests Successful merges: - #145883 (Make macOS dist build configuration match where reasonable) - #146457 (Skip cleanups on unsupported targets) - #147152 (builtin `Fn`-trait impls: instantiate binder before the return type `Sized` check) - #147153 ([rustdoc] Move doc cfg propagation pass before items stripping passes) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Sep 30, 2025
Rollup merge of #147152 - lcnr:instantiate-pre-sized-check, r=BoxyUwU builtin `Fn`-trait impls: instantiate binder before the return type `Sized` check fixes - rust-lang/trait-system-refactor-initiative#220 - rust-lang/trait-system-refactor-initiative#204 r? `@BoxyUwU`
This was referenced Sep 30, 2025
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes
r? @BoxyUwU