Add codegen tests for fshr and clmul#153450
Conversation
|
rustbot has assigned @Mark-Simulacrum. Use Why was this reviewer chosen?The reviewer was selected based on:
|
| @@ -0,0 +1,31 @@ | |||
| //@ compile-flags: -C opt-level=1 | |||
There was a problem hiding this comment.
The carrying_mul_add test used opt-level 1 so I thought I'd use the same here
| //@ compile-flags: -C opt-level=1 | ||
|
|
||
| #![crate_type = "lib"] | ||
| #![feature(core_intrinsics)] |
There was a problem hiding this comment.
Any reason not to call our wrapper around it instead?
There was a problem hiding this comment.
same reason as the rotate_left test.
| #![crate_type = "lib"] | ||
| #![feature(core_intrinsics)] | ||
|
|
||
| use std::intrinsics::rotate_right; |
There was a problem hiding this comment.
Similarly, why isn't this best done via the wrappers?
There was a problem hiding this comment.
This test was done by copying the rotate_left test. I don't know why this isn't done via the wrappers either. I only noticed that the rotate_right intrinsic didn't have any codegen tests.
|
Reminder, once the PR becomes ready for a review, use |
|
@rustbot ready |
|
Error: Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #triagebot on Zulip. |
fshrtest incodegen-llvmclmultest incodegen-llvm