Skip to content

Add codegen tests for fshr and clmul#153450

Open
pvdrz wants to merge 2 commits intorust-lang:mainfrom
ferrocene:pvdrz/llvm-codegen-tests
Open

Add codegen tests for fshr and clmul#153450
pvdrz wants to merge 2 commits intorust-lang:mainfrom
ferrocene:pvdrz/llvm-codegen-tests

Conversation

@pvdrz
Copy link
Copy Markdown
Contributor

@pvdrz pvdrz commented Mar 5, 2026

  • Add fshr test in codegen-llvm
  • Add clmul test in codegen-llvm

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 5, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Mar 5, 2026

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Fallback group: @Mark-Simulacrum, @jieyouxu
  • @Mark-Simulacrum, @jieyouxu expanded to Mark-Simulacrum, jieyouxu
  • Random selection from Mark-Simulacrum, jieyouxu

@@ -0,0 +1,31 @@
//@ compile-flags: -C opt-level=1
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why =1?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The carrying_mul_add test used opt-level 1 so I thought I'd use the same here

//@ compile-flags: -C opt-level=1

#![crate_type = "lib"]
#![feature(core_intrinsics)]
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason not to call our wrapper around it instead?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same reason as the rotate_left test.

#![crate_type = "lib"]
#![feature(core_intrinsics)]

use std::intrinsics::rotate_right;
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly, why isn't this best done via the wrappers?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test was done by copying the rotate_left test. I don't know why this isn't done via the wrappers either. I only noticed that the rotate_right intrinsic didn't have any codegen tests.

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 9, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Mar 9, 2026

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@pvdrz
Copy link
Copy Markdown
Contributor Author

pvdrz commented Mar 13, 2026

@rustbot ready

@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Mar 13, 2026

Error: shortcut handler unexpectedly failed in this comment: failed to remove Label { name: "S-waiting-on-author" }

Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #triagebot on Zulip.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants