set no_mangle_generic_items deny by default#154585
set no_mangle_generic_items deny by default#154585HerrCai0907 wants to merge 1 commit intorust-lang:mainfrom
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
|
r? @oli-obk |
|
|
|
Please make it a hard error and not a lint at all if crater doesn't show any significant regressions. For crater purposes this works. |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
|
@bors try |
This comment has been minimized.
This comment has been minimized.
set no_mangle_generic_items deny by default
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
@craterbot check |
|
👌 Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
|
🚧 Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
|
🎉 Experiment
Footnotes
|
|
I reached out to the jni-mangle author, who used a generic function with The rxdp failure is because (while there are no generics involved in the function signature) the body uses the generic parameter So, let's turn this lint into a hard error. Then we need to write an explainer for T-lang and then we can nominate it. |
In rust-lang/miri#4929 (comment), rustc should reject the no_mangled generic function.
This PR change the default behavior from warn to deny.