Suggest public re-exports when a private module makes an import path inaccessible#154610
Open
jakubadamw wants to merge 4 commits intorust-lang:mainfrom
Open
Suggest public re-exports when a private module makes an import path inaccessible#154610jakubadamw wants to merge 4 commits intorust-lang:mainfrom
jakubadamw wants to merge 4 commits intorust-lang:mainfrom
Conversation
When an import like `use crate::a::b::Item` fails because module `b` is private, the resolver now looks up public re-export paths for `Item` and suggests them to the user.
Collaborator
|
r? @TaKO8Ki rustbot has assigned @TaKO8Ki. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an attempt at solving #13065.
When a
usepath fails because it passes through a private module (E0603), and a public re-export of the target item exists elsewhere, the compiler will now suggest importing through that re-export instead.For example, given:
the compiler will now suggest use
outer::MyStruct; - the publicly accessible path - rather than just pointing at the private module definition and leaving the user to figure out the alternative.When possible, relative paths are suggested, including those using
super(currently capped at a maximum of onesuperpath item).The newly added test is parametrised by editions because of the change in behaviour around
crate::-prefixed imports in edition 2018. Perhaps that’s an overkill – I’ll be happy to remove the variations for editions 2021 and 2024.Closes #13065.