Introduce #[diagnostic::on_move] on Rc#154678
Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom Apr 8, 2026
Merged
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
rustbot has assigned @dingxiangfei2009. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Contributor
Author
Collaborator
|
|
This annotates the `Rc` type with the diagnostic attribute `#[diagnostic::on_move]`. Now when a moved `Rc` is borrowed, a suggestion to clone it is made, with a label explaining why.
rperier
force-pushed
the
diagnostic_on_move_for_the_rc_type
branch
from
309fe1b to
92ed4a2
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
tgross35
approved these changes
Apr 7, 2026
Contributor
rust-bors
bot
added
S-waiting-on-bors
rust-bors bot
pushed a commit
that referenced
this pull request
Apr 8, 2026
Rollup of 4 pull requests Successful merges: - #154460 (Deduplication: Pulled common logic out from lower_const_arg_struct) - #154609 (Enable `#[diagnostic::on_const]` for local impls) - #154678 (Introduce #[diagnostic::on_move] on `Rc`) - #154902 (rustdoc: Inherit inline attributes for declarative macros)
rust-timer
added a commit
that referenced
this pull request
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is related to the tracking issue #154181 and to the original issue #149862.