Merge BuildReducedGraphVisitor into DefPathVisitor#154945
Merge BuildReducedGraphVisitor into DefPathVisitor#154945oli-obk wants to merge 21 commits intorust-lang:mainfrom
Conversation
It loses some diagnostic hint because in contrast to previously, not all definitions have been created yet at the time the diagnostic was emitted. Thus it only sees those items that have been created already, which doesn't include the import in another submodule
|
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…try> Merge visitors def collector brg
This comment has been minimized.
This comment has been minimized.
|
Finished benchmarking commit (5d54692): comparison URL. Overall result: ✅ improvements - no action neededBenchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf. @bors rollup=never Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary 1.9%, secondary 2.0%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (secondary -0.8%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeResults (primary 0.1%, secondary 0.1%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Bootstrap: 487.434s -> 486.262s (-0.24%) |
|
☔ The latest upstream changes (presumably #153838) made this pull request unmergeable. Please resolve the merge conflicts. |
These two visitors run right after each other on the same immutable AST. There's also a hash map for transferring the TyCtxtFeed created in the def collector to the BRG when it visits the same items. There are possibly more avenues for sharing logic, but I want to keep this PR simple.
only opening for perf runs for now. I'm still investigating how to ensure that future changes don't introduce subtle bugs by forgetting that def collection and reduced graph building are one pass now
Best reviewed commit-by-commit. I took a lot of care for making the individual changes reviewable, but all the
Merge *commits aren't able to compile libcore until the last one.