Don't encode doc comments cross-crate#155001
Don't encode doc comments cross-crate#155001JonathanBrouwer wants to merge 1 commit intorust-lang:mainfrom
Conversation
|
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Don't encode doc comments cross-crate
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
This is a good idea (just look at the size of the docs in the stdlib rmeta), and we’ve discussed something like this in the past. The prototype broke the |
|
That feature definitely doesn't work with this PR, looking at the CI failure :c |
|
Perf was good when I tried, reducing stdlib metadata makes every crate load it faster, in rustc and rustdoc, even more so for the benchmarks only using libcore, with its numerous stdarch intrinsics doc comments. |
This comment has been minimized.
This comment has been minimized.
|
Finished benchmarking commit (99dc17f): comparison URL. Overall result: ✅ improvements - no action neededBenchmarking means the PR may be perf-sensitive. It's automatically marked not fit for rolling up. Overriding is possible but disadvised: it risks changing compiler perf. @bors rollup=never Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary -2.8%, secondary -3.7%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary -7.3%, secondary -10.3%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeResults (primary -2.4%, secondary -1.6%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Bootstrap: 490.389s -> 491.393s (0.20%) |
No description provided.