Conversation
|
Failed to set assignee to
|
rustbot
added
S-waiting-on-review
|
This restores the old behavior, but I'm also curious why the relevant code should not run for AssignOp's. |
| if by_ref_binop { | ||
| if let ty::Ref(_, _, mutbl) = method.sig.inputs()[1].kind() { |
There was a problem hiding this comment.
Remark: this condition itself seems a bit fishy, what's even more fishy is that zero tests are failing with or without this condition 🤔
There was a problem hiding this comment.
matches!(op, Op::AssignOp(_)) but not by_ref_binop 🤔
|
@rustbot reroll |
|
Okay, this condition adds an autoref adjustment to the RHS type of comparison operators. It doesn't get catched by test suites probably because ref impl and value impl usually have the same return type. @malezjaa, could you add a test case for this? r? @adwinwhite |
|
It does seems fishy. Let's land the fix first and think about regression test (or the condition's validity) later without worrying about unexpected breakages. I have no time to look into it right now. @bors r+ rollup |
rust-bors
bot
added
S-waiting-on-bors
…adwinwhite Fix if branch in op.rs I removed the if guard without thinking in rust-lang#154223. Really sorry about this. r? @hkBst
…adwinwhite Fix if branch in op.rs I removed the if guard without thinking in rust-lang#154223. Really sorry about this. r? @hkBst
6 participants
I removed the if guard without thinking in #154223. Really sorry about this.
r? @hkBst