Conversation
|
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
src/libcollections/slice.rs
Outdated
There was a problem hiding this comment.
I think these lifetimes (and the corresponding ones on similar methods) can be elided.
There was a problem hiding this comment.
Ah yeah, I wasn't checking for that.
Gankra
force-pushed
the
collections-cleanup
branch
from
84ddc78 to
1be0dc0
Compare
|
@apasel422 I did a quick pass to remove a bunch of useless lifetimes. |
Gankra
force-pushed
the
collections-cleanup
branch
from
acd338e to
22e6a36
Compare
|
@gankro Awesome. Looks good to me! |
|
Nice work @gankro, thanks! Can you also remove the |
|
Oh hey, that shows me all the places I missed. Sweet. New commit with all the missed stuff. |
|
@bors: r+ 9e8aaf2 |
Gankra
force-pushed
the
collections-cleanup
branch
from
9e8aaf2 to
15fb06d
Compare
|
@bors r=alexcrichton 15fb06 p=1 (want to fast track since it's merge-conflicty) |
Gankra
force-pushed
the
collections-cleanup
branch
from
15fb06d to
21f499c
Compare
|
@bors r=alexcrichton 21f49 p=1 |
|
@bors p=0 @Manishearth's rollup'll handle this |
…richton This is 99% burning ints to the ground, but I also got rid of useless annotations or made code more \"idiomatic\" as I went along. Mostly changes in tests.
|
Hmm, I think removing the cc @Manishearth |
|
Wait, I fixed those errors. Hm |
|
Ah, I hadn't run doctests |
|
Oh whoops, I killed my tests before doctests ran. |
|
Merged in rollup with some extra patches |
changes to build scripts and config.toml should always refresh
7 participants
This is 99% burning ints to the ground, but I also got rid of useless annotations or made code more "idiomatic" as I went along. Mostly changes in tests.