Skip to content

Improve error message, when found staticlib instead crate#21978

Merged
bors merged 1 commit intorust-lang:masterfrom
Potpourri:error-extern-crate-staticlib
Feb 7, 2015
Merged

Improve error message, when found staticlib instead crate#21978
bors merged 1 commit intorust-lang:masterfrom
Potpourri:error-extern-crate-staticlib

Conversation

@Potpourri
Copy link
Copy Markdown
Contributor

Add special error for this case and help message please recompile this crate using --crate-type lib, also list found candidates.

See issue #14416

r? @alexcrichton

@rust-highfive
Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see CONTRIBUTING.md for more information.

@alexcrichton
Copy link
Copy Markdown
Member

@bors: r+ 8e3df86

Thanks!

bors added a commit that referenced this pull request Feb 7, 2015
…crichton

Add special error for this case and help message `please recompile this crate using --crate-type lib`, also list found candidates.

See issue #14416

r? @alexcrichton
@bors
Copy link
Copy Markdown
Collaborator

bors commented Feb 7, 2015

⌛ Testing commit 8e3df86 with merge e62fec3...

@bors
Copy link
Copy Markdown
Collaborator

bors commented Feb 7, 2015

@bors bors merged commit 8e3df86 into rust-lang:master Feb 7, 2015
@Potpourri Potpourri deleted the error-extern-crate-staticlib branch February 7, 2015 10:30
lnicola pushed a commit to lnicola/rust that referenced this pull request Apr 9, 2026
…de-placeholders

feat: enhance runnable command placeholders
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants