Consolidating expr_to_str functions.#353
Closed
lkuper wants to merge 1 commit intorust-lang:masterfrom
Closed
Conversation
Contributor
|
Integrated, thanks. |
keeperofdakeys
pushed a commit
to keeperofdakeys/rust
that referenced
this pull request
Dec 12, 2017
Make utmp(x) support more platforms
kazcw
pushed a commit
to kazcw/rust
that referenced
this pull request
Oct 23, 2018
…ang#353) * migrate to rustfmt-preview and require rustfmt to pass * reformat with rustfmt-preview
Aaron1011
pushed a commit
to Aaron1011/rust
that referenced
this pull request
Oct 26, 2020
…e-3.0.7 Bump tempfile from 3.0.5 to 3.0.7
ZuseZ4
pushed a commit
to EnzymeAD/rust
that referenced
this pull request
Mar 7, 2023
workingjubilee
added a commit
to workingjubilee/rustc
that referenced
this pull request
Jul 7, 2023
antoyo
added a commit
to antoyo/rust
that referenced
this pull request
Oct 26, 2023
Fix/int types alignment
celinval
pushed a commit
to celinval/rust-dev
that referenced
this pull request
Jun 4, 2024
…lang#353) * Differentiate between check, codegen, and verification errors. * Fix typo. * Rename tests. * Address concerns. * Remove unnecessary code and fix typos.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Got rid of the redundant expr_to_str in pretty.pprust, and tweaked the signature of the one in util.common to match the one we're replacing.