ICH: Add ability to test the ICH of exported metadata items.#36370
Merged
bors merged 1 commit intorust-lang:masterfrom Sep 24, 2016
Merged
ICH: Add ability to test the ICH of exported metadata items.#36370bors merged 1 commit intorust-lang:masterfrom
bors merged 1 commit intorust-lang:masterfrom
Conversation
24 tasks
Collaborator
|
☔ The latest upstream changes (presumably #35960) made this pull request unmergeable. Please resolve the merge conflicts. |
michaelwoerister
force-pushed
the
incr-comp-metadata-hashes-check
branch
from
cfe6f0d to
560476c
Compare
Contributor
|
@bors r+ |
Collaborator
|
📌 Commit 560476c has been approved by |
Collaborator
|
⌛ Testing commit 560476c with merge 9935022... |
Collaborator
|
💔 Test failed - auto-win-gnu-32-opt-rustbuild |
michaelwoerister
force-pushed
the
incr-comp-metadata-hashes-check
branch
from
560476c to
6a2666d
Compare
Member
Author
|
@bors r=nikomatsakis Deleted a constant that sneaked back in during rebasing. |
Collaborator
|
📌 Commit 6a2666d has been approved by |
Collaborator
bors
added a commit
that referenced
this pull request
Sep 24, 2016
…ck, r=nikomatsakis ICH: Add ability to test the ICH of exported metadata items. Also adds an example test case for ICH testing. r? @nikomatsakis
Collaborator
nnethercote
added a commit
to nnethercote/rust
that referenced
this pull request
Apr 7, 2026
This impl skips over a handful of attributes as if they aren't there. This skipping originated all the way back in rust-lang#36025, and was extended a couple of times, e.g. in rust-lang#36370. Those PRs don't have any explanation of why the skipping exists. Removing the impl (and falling back to the default impl for `[T]`) doesn't seem to have any effects.
nnethercote
added a commit
to nnethercote/rust
that referenced
this pull request
Apr 7, 2026
This impl skips: - All doc comments - A handful of other attributes, mostly `rustc_*` ones related to incremental compilation testing. This skipping originated in rust-lang#36025 and was extended a couple of times, e.g. in rust-lang#36370. Those PRs don't have any explanation of why the skipping exists. Perhaps the reasoning was that doc comments should only affect rustdoc and rustdoc doesn't use incremental compilation? But doc comments end up in metadata, and there is a query `attrs_for_def` that returns a `&'tcx [hir::Attribute]`. So skipping some attributes just seems plainly wrong. This commit removes the impl, which means `[hir::Attribute]` hashing falls back to the default impl for `[T]`. This has no noticeable effect on the test suite. It does slightly hurt performance, because of the doc comments. This perf regression seems worth it for the correcteness benefits.
nnethercote
added a commit
to nnethercote/rust
that referenced
this pull request
Apr 7, 2026
This impl skips: - All doc comments - A handful of other attributes, mostly `rustc_*` ones related to incremental compilation testing. This skipping originated in rust-lang#36025 and was extended a couple of times, e.g. in rust-lang#36370. Those PRs don't have any explanation of why the skipping exists. Perhaps the reasoning was that doc comments should only affect rustdoc and rustdoc doesn't use incremental compilation? But doc comments end up in metadata, and there is a query `attrs_for_def` that returns a `&'tcx [hir::Attribute]`. So skipping some attributes just seems plainly wrong. This commit removes the impl, which means `[hir::Attribute]` hashing falls back to the default impl for `[T]`. This has no noticeable effect on the test suite. It does slightly hurt performance, because of the doc comments. This perf regression seems worth it for the correctness benefits.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also adds an example test case for ICH testing.
r? @nikomatsakis