Implement intra-crate static methods on anonymous trait implementations (e.g. Foo::new())#3776
Closed
pcwalton wants to merge 1 commit intorust-lang:incomingfrom
Closed
Implement intra-crate static methods on anonymous trait implementations (e.g. Foo::new())#3776pcwalton wants to merge 1 commit intorust-lang:incomingfrom
pcwalton wants to merge 1 commit intorust-lang:incomingfrom
Conversation
Contributor
Author
Contributor
|
Looks ok for the most part as far as I can tell, but it's a relatively large amount of code with relatively few comments. I'd just encourage adding more comments before you commit. r+ |
Contributor
Author
RalfJung
pushed a commit
to RalfJung/rust
that referenced
this pull request
Aug 5, 2024
Use Scalar consistently in foreign item emulation Step 0 of rust-lang#3772 This just makes the code consistent. While we could also go for consistency the other way, that would only allow us to use integers in some cases where we use `Scalar` right now, because `Scalar` can also hold pointers where applicable. There's also no danger in messing up (even though we do lose some compile-time checks), as `Scalar` knows the size of the integer stored within, so it will check that against the destination when it is written. In fact, this makes the checks much stronger compared with `write_int`, which just checks that the integer fits into the destination size.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.