Call default methods on bound typarams more correctly#4101
Merged
brson merged 1 commit intorust-lang:incomingfrom Dec 7, 2012
Merged
Call default methods on bound typarams more correctly#4101brson merged 1 commit intorust-lang:incomingfrom
brson merged 1 commit intorust-lang:incomingfrom
Conversation
Contributor
Author
|
This also doesn't handle the cross-crate case in trans. |
Contributor
|
r=me |
brson
added a commit
that referenced
this pull request
Dec 7, 2012
Call default methods on bound typarams more correctly
RalfJung
added a commit
to RalfJung/rust
that referenced
this pull request
Dec 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? @pcwalton
This makes test cases like the following work:
What doesn't work is if trait A is itself parameterized. This commit includes such testcases, xfailed. As with each of my commits to traits, the hacks involved make me feel uncomfortable. Trans isn't told specifically that it's implementing a default method - instead method lookup on the impl fails so trans decides that must be what's going on then starts grovelling for default implementations.