Merged
Conversation
Contributor
|
r? @sfackler (rust_highfive has picked a reviewer for you, use r? to override) |
Contributor
Author
|
cc @alexcrichton and #40380 |
Member
|
Seems reasonable to me, thanks! Looks like |
Contributor
Author
|
Oh, huh, you're right. Will fix. |
clarfonthey
force-pushed
the
as_extras
branch
2 times, most recently
from
8b6f161 to
84e176b
Compare
Contributor
Author
|
Passes now! Ready to merge. |
Member
|
@bors: r+ |
Collaborator
|
📌 Commit 68909b0 has been approved by |
Collaborator
|
⌛ Testing commit 68909b0 with merge f31dcc0... |
Collaborator
|
💔 Test failed - status-travis |
Contributor
Collaborator
bors
added a commit
that referenced
this pull request
Apr 9, 2017
Add as_c_str Again, tying up some consistencies with `CString`.
Collaborator
|
☀️ Test successful - status-appveyor, status-travis |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Again, tying up some consistencies with
CString.