Assign correct types to struct-like enum variant constructors#4233
Closed
catamorphism wants to merge 1 commit intorust-lang:incomingfrom
Closed
Assign correct types to struct-like enum variant constructors#4233catamorphism wants to merge 1 commit intorust-lang:incomingfrom
catamorphism wants to merge 1 commit intorust-lang:incomingfrom
Conversation
Before, the type was just the enum type itself, which caused an assertion failure in iter_variant in trans::base. As per rust-lang#4229
Contributor
|
r+ |
Contributor
Author
|
Good question, I wasn't thinking about that. Before pushing this, I'll add a test case that checks that a struct-like enum constructor can be invoked with permuted arguments. |
ghost
assigned
Contributor
Author
|
Merged. (Changing the order just works, I added a test case -- probably b/c the typechecker doesn't look at the type for the constructor, only trans does.) |
RalfJung
added a commit
to RalfJung/rust
that referenced
this pull request
Mar 28, 2025
Automatic Rustup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before, the type was just the enum type itself, which caused an
assertion failure in iter_variant in trans::base.
As per #4229
r? @brson