Tutorial additions, restructuring, simplification#4240
Closed
brson wants to merge 26 commits intorust-lang:incomingfrom
Closed
Tutorial additions, restructuring, simplification#4240brson wants to merge 26 commits intorust-lang:incomingfrom
brson wants to merge 26 commits intorust-lang:incomingfrom
Conversation
Has to be moved until after the pointer discussion. /cc: rust-lang#4217
This takes up a lot of words and isn't very clear. The previous discussion gets they idea across. /cc: rust-lang#4217
It's not interesting /cc: rust-lang#4217
We can mention that constants are declared with 'const' in one line. Don't need an entire section.
Contributor
|
r+ from where I stand. I'm a little ambivalent about the losses of the types, constants and semicolon discussions, but can also see them as distracting and/or too verbose, which I assume was why you removed them. |
There was a problem hiding this comment.
typo? I'm not sure what the intent is here...
Contributor
Author
|
@graydon I've heard criticism that the tutorial takes to long to get to the interesting parts of Rust, and I agree, so I was looking for big swaths to delete. |
Contributor
|
Sorry I didn't get to reviewing this on time; I'm still on leave this week, though sporadically working on things. |
Contributor
Author
|
No worries |
RalfJung
added a commit
to RalfJung/rust
that referenced
this pull request
Mar 28, 2025
run a few more concurrency tests on aarch64-linux-android
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? @TJC
This makes some significant changes to your work on static methods and trait inheritance, moving most of the static method discussion to the section on methods, adding explicit self everywhere, deleting a bunch of uninteresting and rote material from the syntax basics section and trying to reintegrate the most important parts in passing.
Because explicit self requires talking about pointers I broke the section on functions and methods into two sections. functions comes before pointers and methods comes after, just before generics.