Use identity operator is when comparing to None#45120
Merged
bors merged 1 commit intorust-lang:masterfrom Oct 10, 2017
johnthagen:none-identity-test
Merged
Use identity operator is when comparing to None#45120bors merged 1 commit intorust-lang:masterfrom johnthagen:none-identity-test
is when comparing to None#45120bors merged 1 commit intorust-lang:masterfrom
johnthagen:none-identity-test
Conversation
Contributor
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
Member
|
@bors r+ rollup |
Collaborator
|
📌 Commit d9e6703 has been approved by |
carols10cents
added
the
S-waiting-on-bors
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Oct 9, 2017
…ackler Use identity operator `is` when comparing to None This is very minor, but idiomatic Python code uses `is` for comparisons to `None`. This is because semantically we want to compare to the "identity" of `None`, not its value. See [PEP8 for details](https://www.python.org/dev/peps/pep-0008/#programming-recommendations).
bors
added a commit
that referenced
this pull request
Oct 10, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is very minor, but idiomatic Python code uses
isfor comparisons toNone. This is because semantically we want to compare to the "identity" ofNone, not its value.See PEP8 for details.