rustbuild: Build stage 1 error index generator at stage 0#45432
Merged
bors merged 1 commit intorust-lang:masterfrom Oct 22, 2017
Merged
rustbuild: Build stage 1 error index generator at stage 0#45432bors merged 1 commit intorust-lang:masterfrom
bors merged 1 commit intorust-lang:masterfrom
Conversation
At stage 1 rustdoc is built at stage 0 so the error index generator should be as well. This fixes `x.py --stage 1 doc` as rustdoc doesn't even build at stage 1.
kennytm
added
the
S-waiting-on-review
Member
|
@bors r+ Thanks! |
Collaborator
|
📌 Commit 2045e07 has been approved by |
kennytm
added
S-waiting-on-bors
Collaborator
|
⌛ Testing commit 2045e07 with merge 3bb8695532d14a1a8171ff072c1c9fc5baff122e... |
Collaborator
|
💔 Test failed - status-appveyor |
Member
|
@bors retry
|
Collaborator
bors
added a commit
that referenced
this pull request
Oct 22, 2017
…lacrum rustbuild: Build stage 1 error index generator at stage 0 At stage 1 rustdoc is built at stage 0 so the error index generator should be as well. This fixes `x.py --stage 1 doc` as rustdoc doesn't even build at stage 1. It was broken by #44605. r? @alexcrichton
Collaborator
|
☀️ Test successful - status-appveyor, status-travis |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At stage 1 rustdoc is built at stage 0 so the error index generator should be as well.
This fixes
x.py --stage 1 docas rustdoc doesn't even build at stage 1.It was broken by #44605.
r? @alexcrichton