remove erroneous error message when checking impl trait params

[tinaun]

fixes #48703

[rust-highfive]

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

[tinaun]

i don't really like my solution here, but idk if doing the test in both functions would be any better

[eddyb]

r? @nikomatsakis

[nikomatsakis]

Seems good to me, the only nit is in the name of the parameter, which could be clearer I think.

[nikomatsakis]

Nit: lots of bool parameters can get sorta hard to read. I like to do:

struct IsMethodCall(bool);
struct IsImplTrait(bool);

and then use those types instead of plain bool. Then the caller can do check_path_parameter_count(span, segment, IsMethodCall(true), IsImplTrait(false)) or whatever. Inside the function, you can read the value by doing is_method_call.0.

[nikomatsakis]

But in any case I kind of think the name is_impl_trait is not very informative. How about suppress_mismatch_error or something?

[nikomatsakis]

@tinaun -- do you think you'll have a chance to address the nit above? ❤️

[shepmaster]

@nikomatsakis looks like there has been new code pushed!

[nikomatsakis]

True, although it did not address my nit. That's ok, I don't care that much, but @tinaun you will need to fix this travis error:

https://travis-ci.org/rust-lang/rust/builds/353614751#L1817

r=me once green

[emilyalbini]

@tinaun ping from triage! The travis build is failing, could you fix that so the PR can be merged?

[nikomatsakis]

@bors r+

[bors]

📌 Commit 97e0dc3 has been approved by nikomatsakis

[bors]

⌛ Testing commit 97e0dc3 with merge 290420ba65d7e5829826c9cd84d20d9a923e3138...

[alexcrichton]

@bors: retry

prioritizing rollup with this included in it

[bors]

⌛ Testing commit 97e0dc3 with merge 4bf76d6...

[bors]

☀️ Test successful - status-appveyor, status-travis
Approved by: nikomatsakis
Pushing 4bf76d6 to master...