Skip to content

Attempt to debug 259 exit code on AppVeyor#57975

Merged
bors merged 1 commit intorust-lang:masterfrom
alexcrichton:debug-exit-appveyor
Jan 30, 2019
Merged

Attempt to debug 259 exit code on AppVeyor#57975
bors merged 1 commit intorust-lang:masterfrom
alexcrichton:debug-exit-appveyor

Conversation

@alexcrichton
Copy link
Copy Markdown
Member

@alexcrichton alexcrichton commented Jan 29, 2019

Let's try to dig in a bit more and see where this is coming from, it
looks like AppVeyor is also unsure where this is coming from!

@alexcrichton
Attempt to debug 259 exit code on AppVeyor
ce279a8 
Let's try to dig in a bit more and see where this is coming from, it
looks like AppVeyor is also unsure where this is coming from!
@rust-highfive
Copy link
Copy Markdown
Contributor

rust-highfive commented Jan 29, 2019

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 29, 2019
@alexcrichton
Copy link
Copy Markdown
Member Author

alexcrichton commented Jan 29, 2019

This came out with some discussion I've been having with them.

@alexcrichton
Copy link
Copy Markdown
Member Author

alexcrichton commented Jan 29, 2019

r? @pietroalbini

@emilyalbini
Copy link
Copy Markdown
Member

emilyalbini commented Jan 29, 2019

@bors r+

@bors
Copy link
Copy Markdown
Collaborator

bors commented Jan 29, 2019

📌 Commit ce279a8 has been approved by pietroalbini

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 29, 2019
@nagisa
Copy link
Copy Markdown
Member

nagisa commented Jan 29, 2019

NB: you can RDP directly into an appveyor machine, so perhaps setting that up would help?

@alexcrichton
Copy link
Copy Markdown
Member Author

alexcrichton commented Jan 29, 2019

Unfortunately we don't typically get a chance to see and debug these failures until hours after the build has finished. Additionally they're often spurious, and we can't be watching every single build.

@Centril
Copy link
Copy Markdown
Contributor

Centril commented Jan 30, 2019

@bors p=1

Adjusting queue order relative to rollup.

@bors
Copy link
Copy Markdown
Collaborator

bors commented Jan 30, 2019

⌛ Testing commit ce279a8 with merge d3d0bf0...

bors added a commit that referenced this pull request Jan 30, 2019
@bors
Auto merge of #57975 - alexcrichton:debug-exit-appveyor, r=pietroalbini
d3d0bf0 
Attempt to debug 259 exit code on AppVeyor

Let's try to dig in a bit more and see where this is coming from, it
looks like AppVeyor is also unsure where this is coming from!
@bors
Copy link
Copy Markdown
Collaborator

bors commented Jan 30, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: pietroalbini
Pushing d3d0bf0 to master...

@bors
Copy link
Copy Markdown
Collaborator

bors commented Jan 30, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: pietroalbini
Pushing d3d0bf0 to master...

@bors bors merged commit ce279a8 into rust-lang:master Jan 30, 2019
@emilyalbini emilyalbini mentioned this pull request Feb 4, 2019
Closed
@emilyalbini
Copy link
Copy Markdown
Member

emilyalbini commented Feb 4, 2019

Still happening, opened a tracking issue in #58160.

emilyalbini added a commit to emilyalbini/rust that referenced this pull request Feb 6, 2019
@emilyalbini
Revert "Auto merge of rust-lang#57975 - alexcrichton:debug-exit-appve…
9959924 
…yor, r=pietroalbini"

This reverts commit d3d0bf0, reversing
changes made to 40e6a0b.
@alexcrichton alexcrichton deleted the debug-exit-appveyor branch March 12, 2019 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@emilyalbini emilyalbini

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@alexcrichton @rust-highfive @emilyalbini @bors @nagisa @Centril @nikomatsakis