resolve: Improve candidate search for unresolved macro suggestions#62684
Merged
bors merged 8 commits intorust-lang:masterfrom Jul 19, 2019
Merged
resolve: Improve candidate search for unresolved macro suggestions#62684bors merged 8 commits intorust-lang:masterfrom
bors merged 8 commits intorust-lang:masterfrom
Conversation
rust-highfive
added
the
S-waiting-on-review
petrochenkov
commented
Jul 15, 2019
davidtwco
approved these changes
Jul 17, 2019
Member
davidtwco
left a comment
davidtwco
left a comment
There was a problem hiding this comment.
LGTM, r=me if you're happy with this.
Contributor
Author
|
@bors r=davidtwco |
Collaborator
|
📌 Commit 4ffa0bb50dd9c48360c9b3d40985f830800ce724 has been approved by |
bors
added
S-waiting-on-bors
Collaborator
|
☔ The latest upstream changes (presumably #62669) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
S-waiting-on-author
Also move it into the crate root, it's no longer used for macros only
… is enabled Normally `#![feature(...)]` shouldn't change behavior, but custom attributes in particular are in the process of retirement, and we should not produce a message telling to enable them. It also helps with unifying diagnostics for unresolved macros.
Contributor
Author
|
@bors r=davidtwco |
Collaborator
|
📌 Commit 1b4fbfc has been approved by |
bors
removed
the
S-waiting-on-author
Collaborator
bors
added a commit
that referenced
this pull request
Jul 19, 2019
resolve: Improve candidate search for unresolved macro suggestions Use same scope visiting machinery for both collecting suggestion candidates and actually resolving the names. The PR is better read in per-commit fashion with whitespace changes ignored (the first commit in particular moves some code around). This should be the last pre-requisite for #62086. r? @davidtwco
Collaborator
|
☀️ Test successful - checks-azure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use same scope visiting machinery for both collecting suggestion candidates and actually resolving the names.
The PR is better read in per-commit fashion with whitespace changes ignored (the first commit in particular moves some code around).
This should be the last pre-requisite for #62086.
r? @davidtwco