Stabilize Result::as_deref and as_deref_mut#74948
Merged
bors merged 3 commits intorust-lang:masterfrom Aug 3, 2020
Merged
Conversation
Member
|
@bors r+ |
Collaborator
|
📌 Commit 68017c2d4ad7018696e56219bceb3d878801acb0 has been approved by |
Member
|
@bors r- Libcore tests need to be updated. error[E0599]: no method named `as_deref_err` found for reference `&std::result::Result<u8, &i32>` in the current scope
--> library/core/tests/result.rs:257:24
|
257 | assert_eq!(ref_err.as_deref_err(), expected_result);
| ^^^^^^^^^^^^ method not found in `&std::result::Result<u8, &i32>` |
68017c2 to
0b61b61
Compare
0b61b61 to
6d293ed
Compare
tesuji
commented
Jul 31, 2020
Member
|
@bors r+ |
Collaborator
|
📌 Commit 6d293ed has been approved by |
Collaborator
Collaborator
|
☀️ Test successful - checks-actions, checks-azure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FCP completed in #50264 (comment).
This PR stabilizes two methods for
std::result::Result:This PR also removes two rarely used unstable methods from
Result:Closes #50264