remove allow(incomplete_features) from std#80591
Merged
bors merged 1 commit intorust-lang:masterfrom Jan 3, 2021
Merged
Conversation
rust-highfive
added
the
S-waiting-on-review
lcnr
changed the title
This comment has been minimized.
This comment has been minimized.
lcnr
force-pushed
the
incomplete-features
branch
from
3382703 to
6cf47ff
Compare
Member
|
Ah, this is great, thanks. :) Do you know if the one in |
Collaborator
|
📌 Commit 6cf47ff has been approved by |
bors
added
S-waiting-on-bors
Contributor
Author
|
i think we can also remove in stdarch 😆 didn't want to touch a subrepo though |
Collaborator
|
⌛ Testing commit 6cf47ff with merge 6c3de8712845df75ed8ba8a17a0e840c27f8cdb4... |
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Collaborator
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
Contributor
Author
|
looks spurious to me @bors r=RalfJung rollup |
Collaborator
|
💡 This pull request was already approved, no need to approve it again.
|
Collaborator
|
📌 Commit 6cf47ff has been approved by |
bors
added
S-waiting-on-bors
Member
|
@bors retry |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 3, 2021
…laumeGomez Rollup of 5 pull requests Successful merges: - rust-lang#80580 (Add suggestion for "ignore" doc code block) - rust-lang#80591 (remove allow(incomplete_features) from std) - rust-lang#80617 (Detect invalid rustdoc test commands) - rust-lang#80628 (reduce borrowing and (de)referencing around match patterns (clippy::match_ref_pats)) - rust-lang#80646 (Clean up in `each_child_of_item`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc #80349 (comment)
I think it is theoretically ok to use incomplete features in the standard library or the compiler if we know that there is an already working subset and we explicitly document what we have to be careful about. Though at that point it is probably better to try and split the incomplete feature into two separate ones, similar to
min_specialization.Will be interesting once
feature(const_evaluatable_checked)works well enough to imo be used in the compiler but not yet well enough to be removed fromINCOMPLETE_FEATURES.r? @RalfJung