alloc: no_global_oom_handling: disable new()s, pin()s, etc.#86810
Merged
bors merged 1 commit intorust-lang:masterfrom Jul 3, 2021
Merged
alloc: no_global_oom_handling: disable new()s, pin()s, etc.#86810bors merged 1 commit intorust-lang:masterfrom
no_global_oom_handling: disable new()s, pin()s, etc.#86810bors merged 1 commit intorust-lang:masterfrom
Conversation
They are infallible, and could not be actually used because they will trigger an error when monomorphized, but it is better to just remove them. Link: Rust-for-Linux/linux#402 Suggested-by: Gary Guo <gary@garyguo.net> Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
Contributor
|
r? @dtolnay (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Contributor
Author
|
Paging @nbdd0121 @bjorn3 @Ericson2314. |
7 tasks
Ericson2314
approved these changes
Jul 2, 2021
Member
|
@bors r+ |
Collaborator
|
📌 Commit 7775dff has been approved by |
bors
added
S-waiting-on-bors
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
Contributor
|
BTW @ojeda, the double negation in |
Member
|
A default-on |
Contributor
Author
|
@kornelski Note that this PR did not add the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
They are infallible, and could not be actually used because
they will trigger an error when monomorphized, but it is better
to just remove them.
Link: Rust-for-Linux/linux#402
Suggested-by: Gary Guo gary@garyguo.net
Signed-off-by: Miguel Ojeda ojeda@kernel.org