Merged
Conversation
Contributor
|
r? @kennytm (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
fee1-dead
force-pushed
the
const-deref
branch
from
32edaa9 to
9b04182
Compare
Member
|
r? @oli-obk |
oli-obk
requested changes
Sep 13, 2021
Contributor
oli-obk
left a comment
oli-obk
left a comment
There was a problem hiding this comment.
Please create a tracking issue or point to the const trait impls tracking issue.
Also include a short message in the main post explaining what this PR does.
I think this PR would also benefit from a test or two
fee1-dead
force-pushed
the
const-deref
branch
from
9b04182 to
439e356
Compare
3 tasks
fee1-dead
force-pushed
the
const-deref
branch
from
439e356 to
349ac4f
Compare
Contributor
|
@bors r+ rollup |
Collaborator
|
📌 Commit 349ac4f has been approved by |
bors
added
S-waiting-on-bors
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Sep 16, 2021
Const Deref Implements `const Deref`/`const DerefMut` for `&mut T`, `&T`, `Cow<'_, B>` and `ManuallyDrop<T>`
Member
|
Does |
Contributor
yes, and there are explicit tests for this |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 17, 2021
Rollup of 10 pull requests Successful merges: - rust-lang#86382 (Make diagnostics clearer for `?` operators) - rust-lang#87529 (Fix ICE in `improper_ctypes_definitions` lint with all-ZST transparent types) - rust-lang#88339 (Add TcpListener::into_incoming and IntoIncoming) - rust-lang#88735 (Don't lint about missing code examples in derived traits) - rust-lang#88751 (Couple of changes to FileSearch and SearchPath) - rust-lang#88883 (Move some tests to more reasonable directories - 7) - rust-lang#88887 (Const Deref) - rust-lang#88911 (Improve error message for type mismatch in generator arguments) - rust-lang#89014 (PassWrapper: handle separate Module*SanitizerPass) - rust-lang#89033 (Set the library path in sysroot-crates-are-unstable) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements
const Deref/const DerefMutfor&mut T,&T,Cow<'_, B>andManuallyDrop<T>