Merged
Conversation
In rust-lang#89522 we learned that `clone3` is interacting poorly with Gentoo's `sandbox` tool. We only need that for the unstable pidfd extensions, so otherwise avoid that and use a normal `fork`.
Co-authored-by: Josh Triplett <josh@joshtriplett.org>
This reverts commit 12fbabd. It was only needed because of using raw `clone3` instead of `fork`, but we only do that now when a pidfd is requested.
Co-authored-by: Josh Triplett <josh@joshtriplett.org>
Co-authored-by: Josh Triplett <josh@joshtriplett.org>
This is the last step in landing rust-lang/miri#1340!
Only use `clone3` when needed for pidfd In rust-lang#89522 we learned that `clone3` is interacting poorly with Gentoo's `sandbox` tool. We only need that for the unstable pidfd extensions, so otherwise avoid that and use a normal `fork`. This is a re-application of beta rust-lang#89924, now that we're aware that we need more than just a temporary release fix. I also reverted 12fbabd, as that was just fallout from using `clone3` instead of `fork`. r? `@Mark-Simulacrum` cc `@joshtriplett`
…=Amanieu adjust documented inline-asm register constraints This change more clearly specifies how `reg` and `reg_thumb` work with ARM, Thumb2, and Thumb1 code. Based upon the [llvm documentation](https://llvm.org/docs/LangRef.html#supported-constraint-code-list) for register constraint codes. To be clear, this just updates the docs to match what already happens with rustc/llvm. No change in the compiler is required to make it match this new documentation.
Update Miri Fixes rust-lang#90763. This is the last step in landing rust-lang/miri#1340! r? `@RalfJung`
Member
Author
|
@bors r+ rollup=never p=3 |
Collaborator
|
📌 Commit 17cb2b6 has been approved by |
bors
added
the
S-waiting-on-bors
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
rust-highfive
added a commit
to rust-lang-nursery/rust-toolstate
that referenced
this pull request
Nov 11, 2021
Tested on commit rust-lang/rust@8e02931. Direct link to PR: <rust-lang/rust#90784> 🎉 miri on windows: build-fail → test-pass (cc @eddyb @oli-obk @RalfJung). 🎉 miri on linux: build-fail → test-pass (cc @eddyb @oli-obk @RalfJung).
Closed
Collaborator
|
Finished benchmarking commit (8e02931): comparison url. Summary: This benchmark run did not return any relevant changes. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
clone3when needed for pidfd #89930 (Only useclone3when needed for pidfd)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup