Some more EarlyBinder cleanups#99038
Merged
bors merged 4 commits intorust-lang:masterfrom Jul 12, 2022
Merged
Conversation
rustbot
added
the
T-compiler
rust-highfive
added
the
S-waiting-on-review
Collaborator
|
Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt |
jackh726
force-pushed
the
earlybinder-cleanup
branch
from
0ad248e to
ad9e1e3
Compare
lcnr
reviewed
Jul 8, 2022
Contributor
lcnr
left a comment
lcnr
left a comment
There was a problem hiding this comment.
r=me after dealing with my comment in any way you see fit
| @@ -1812,8 +1810,11 @@ impl<'a, 'tcx> ProbeContext<'a, 'tcx> { | |||
| } | |||
|
|
|||
| /// Gets the type of an impl and generate substitutions with placeholders. | |||
Contributor
There was a problem hiding this comment.
Suggested change
| /// Gets the type of an impl and generate substitutions with placeholders. | |
| /// Gets the type of an impl and generate substitutions with inference vars. |
though really, impl_ty_and_substs should be replaced with a function which just eagerly calls subst.
jackh726
commented
Jul 11, 2022
Member
Author
|
@bors r=lcnr |
Collaborator
bors
added
S-waiting-on-bors
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Jul 11, 2022
Some more `EarlyBinder` cleanups First commit has a couple unrelated cleanups, but otherwise each commit is self-explanatory r? rust-lang/types
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Jul 12, 2022
Some more `EarlyBinder` cleanups First commit has a couple unrelated cleanups, but otherwise each commit is self-explanatory r? rust-lang/types
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Jul 12, 2022
Some more `EarlyBinder` cleanups First commit has a couple unrelated cleanups, but otherwise each commit is self-explanatory r? rust-lang/types
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 12, 2022
Rollup of 6 pull requests Successful merges: - rust-lang#98622 (rustc_target: Flip the default for `TargetOptions::executables` to true) - rust-lang#98633 (Fix last `let_chains` blocker) - rust-lang#98972 (Suggest adding a missing zero to a floating point number) - rust-lang#99038 (Some more `EarlyBinder` cleanups) - rust-lang#99154 (use PlaceRef::iter_projections to fix old FIXME) - rust-lang#99171 (Put back UI test regex) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First commit has a couple unrelated cleanups, but otherwise each commit is self-explanatory
r? rust-lang/types