Fix UB in _mm_movemask_ps, _mm_movemask_pd, _mm256_movemask_ps and _mm256_movemask_pd#1482
Merged
Amanieu merged 1 commit intorust-lang:masterfrom Oct 12, 2023
eduardosm:movemask
Merged
Fix UB in _mm_movemask_ps, _mm_movemask_pd, _mm256_movemask_ps and _mm256_movemask_pd#1482Amanieu merged 1 commit intorust-lang:masterfrom eduardosm:movemask
Amanieu merged 1 commit intorust-lang:masterfrom
eduardosm:movemask
Conversation
Collaborator
|
r? @Amanieu (rustbot has picked a reviewer for you, use r? to override) |
…m256_movemask_pd The `simd_bitmask` intrinsic requires each element to be all-1 or all-0, while the x86 functions only check for the highest bit.
Contributor
Author
|
Hmmm |
Member
|
Can you do a quick test on godbolt to ensure this still compiles down to 1 instruction? |
Contributor
Author
|
Of course: https://godbolt.org/z/n6EMz7dbv |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
simd_bitmaskintrinsic requires each element to be all-1 or all-0, while the x86 functions only check for the highest bit.