Add note about floating point weights in update_weights docs#1280
Add note about floating point weights in update_weights docs#1280dhardy merged 4 commits intorust-random:masterfrom
Conversation
|
Thanks for the PR. But I don't understand the motivation — is it a warning that you have noticed inaccuracies in the result after using That inaccuracies can occur when using floating point values is one of the basics of Computer Science. Example (which could occur in As for special treatment for weights which are zero: is your point that |
Yep! I should've been clearer about the motivation. It's only meant to help avoid confusion around
Yeah, it's trivial to do that outside of |
|
Okay, I'll go with this. Ignoring the CI failure on MIPS (unrelated). |
Motivation
To highlight that
update_weightsmay not returnWeightedError::AllWeightsZerowhen all weights are zero when updating floating-point weights.